-
-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Expand link validation, add configs for it #3283
Conversation
And use attribute access for configs in more places
Expand the situations where logs about broken links are produced, make the logging levels fully configurable
Guess what existing page might have been meant based on the provided link, and mention it in the log message.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me, though my approval does not have a lot of value: I'm not particularly familiar with the code base.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That's a deep one 👍
Just FYI, this PR broke at least one plugin, that relied on |
Closes #1755 and a lot more