Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expand link validation, add configs for it #3283

Merged
merged 7 commits into from
Jul 9, 2023
Merged

Expand link validation, add configs for it #3283

merged 7 commits into from
Jul 9, 2023

Conversation

oprypin
Copy link
Contributor

@oprypin oprypin commented Jul 2, 2023

  • Expand the situations where logs about broken links are produced, make the logging levels fully configurable
  • Guess what existing page might have been meant based on the provided link, and mention it in the log message.

Closes #1755 and a lot more

And use attribute access for configs in more places
Expand the situations where logs about broken links are produced, make the logging levels fully configurable
Guess what existing page might have been meant based on the provided link, and mention it in the log message.
Copy link
Sponsor Contributor

@pawamoy pawamoy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, though my approval does not have a lot of value: I'm not particularly familiar with the code base.

Copy link
Member

@ultrabug ultrabug left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's a deep one 👍

@oprypin oprypin merged commit 89c7aa6 into master Jul 9, 2023
29 of 30 checks passed
@oprypin oprypin deleted the warnc branch July 9, 2023 14:04
@Lucas-C
Copy link

Lucas-C commented Aug 4, 2023

Just FYI, this PR broke at least one plugin, that relied on _RelativePathExtension:
greenape/mknotebooks#1100

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add ability to warn about pages existing in the docs directory but not included in the "nav" configuration
4 participants