Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow adding event handlers at multiple priorities #3448

Merged
merged 2 commits into from Nov 8, 2023
Merged

Allow adding event handlers at multiple priorities #3448

merged 2 commits into from Nov 8, 2023

Conversation

oprypin
Copy link
Contributor

@oprypin oprypin commented Oct 29, 2023

-within one plugin.

@squidfunk
Copy link
Sponsor Contributor

Why do you think this should be supported?

@oprypin
Copy link
Contributor Author

oprypin commented Oct 29, 2023

I think a better question is why shouldn't it be supported. Right now it's a limitation based only on how it's implemented. If someone was designing this system anew, surely they wouldn't say that it's better that you can't have an early on_files handler if you already have a late handler for it.

@squidfunk
Copy link
Sponsor Contributor

Okay, so I read that there's no immediate need why this get's implemented, but it's a nice-to-have. From a plugin author's perspective, I'm not sure it's necessary, though. At least, I haven't seen one sound use case that would mandate for it.

Copy link
Member

@ultrabug ultrabug left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I love the idea and can clearly see use cases, thanks!

@oprypin oprypin merged commit dc45916 into master Nov 8, 2023
30 checks passed
@oprypin oprypin deleted the combi branch November 8, 2023 17:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants