Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BUG: Does not work with Node 20 LTS #40

Closed
janthony6 opened this issue Oct 25, 2023 · 13 comments
Closed

BUG: Does not work with Node 20 LTS #40

janthony6 opened this issue Oct 25, 2023 · 13 comments
Assignees
Labels
known issue This issue has been reported multiple times

Comments

@janthony6
Copy link

With Node 20, konnected doesn't read any contact sensor states. I can trigger the alarm manually in the HomeKit app, but nothing else works. Door open when the alarm is armed won't trigger the alarm. With node 20, a fresh install of a pro board won't pair either.

@janthony6 janthony6 added the bug Something isn't working label Oct 25, 2023
@racerx9146
Copy link

I believe I am having the same issue. I am on v20.9.0

@mkormendy mkormendy added known issue This issue has been reported multiple times and removed bug Something isn't working labels Dec 27, 2023
@mkormendy
Copy link
Owner

Correct, this plugin has not been updated to work with Node 20. I will endeavor to work on this in January as I finally have a home to test the boards against the installed alarm system here.

@racerx9146
Copy link

racerx9146 commented Dec 27, 2023 via email

@benkemal
Copy link

Hi @mkormendy, just wanted to check if any update on Node 20 support?

I'm having issues with my setup when trying to roll back to homebridge version on Node 18, so just wanted to check if this issue is likely to be be updated soon before I spend too much more time trying to rebuild my setup.

@mkormendy
Copy link
Owner

Good news, I've recently upgraded my system that I do my development with to Node 21 and slowly upgrading all of my other applications that use v20+.

I'd like to also make this backward compatible so people who are locked in at the lowest supported version that the current code is running on, is not affected by any breaking changes introduced in the v20+ update.

I'll have to write some deployment tests to verify that too.

@darrenmadams
Copy link

I believe from reading some other forums that I am having the same problem. I'm getting an error "The panel at http://192.168.4.80:15300/settings has disconnected and is likely rebooting to apply new provisioning settings" and after resetting everything on the hardware, reinstalling homebridge-konnected, re-adding to Home I don't have any sensors being created or triggered.

I was able to roll back cleanly by running "sudo hb-service update-node 18.18.0" but that broke other plugins. I tried to use npm to rebuild but it just hung so I uninstalled and reinstalled and reconfigured them and it looks like they're still complaining so it would be nice to have support for v20 in this plugin. Thanks!

@janthony6
Copy link
Author

homebridge wants us all to be on node20. is there any way to release the node20 compatible version. anyone that has it broken by that update can easily update to node20.

@mkormendy
Copy link
Owner

mkormendy commented Mar 19, 2024

So I've upgraded my dev setup to node v21.7.1 and I can't seem to reproduce the problem.

To anyone that upgrades to node v21.7.1 and is having problems from what is seen in v20, try emptying the cachedAccessories per the wiki doc.

Let me know on Discord if you have issues still and I can interactively troubleshoot.

@mkormendy mkormendy changed the title Does not work with Node 20 LTS BUG: Does not work with Node 20 LTS Mar 19, 2024
@HughesAndrewC
Copy link

I just updated from 18.19.0 to 20.11.1 and the beeper-switches I have configured no longer work. I also have the same problem as above, the alarm will no longer trigger after opening a door while the alarm is armed. Downgrading back to 18.19.0 resolved both issues. Lucky for me, other plugins I'm running do not seem to depend on v20.

@mkormendy
Copy link
Owner

As asked, please update to 21.7.1 and let me know if that fixes things.

@benkemal
Copy link

@mkormendy per the Homebridge wiki, it mentions that "Homebridge does not support odd-numbered releases of Node.js, such as 19.x and 21.x."

Any chance we can get a fix that supports v20? I don't want this to break other plugins in use and also as I'm running Homebridge on Synology, I don't think it's currently possible for me to upgrade to v21 as I don't think they have released a node v21 package.

@mkormendy
Copy link
Owner

@benkemal I've successfully reproduced the problem, and it has to do with a number of breaking changes that occur in packages that need upgrading to work with Node20. Unfortunately this has also affected my plugin severely as well, and I have gone to "the point of no-return" - meaning I am actively rewriting/refactoring the plugin to bring it up to current standards.

@mkormendy
Copy link
Owner

I believe the problem is now related to this: node-fetch/node-fetch#1735 .. looking into fixes to node-fetch and/or using Axios.

mkormendy added a commit that referenced this issue Apr 2, 2024
… keepalive defaults which caused implications with the node-fetch module used.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
known issue This issue has been reported multiple times
Projects
Development

No branches or pull requests

6 participants