Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Menu animation on page change doesn't feel smooth #19

Open
ljcp opened this issue Jul 5, 2017 · 4 comments
Open

Menu animation on page change doesn't feel smooth #19

ljcp opened this issue Jul 5, 2017 · 4 comments

Comments

@ljcp
Copy link

ljcp commented Jul 5, 2017

when you navigate to another page example "About" the menu feels like it is closed too fast and without progressive transition

@Wigdo
Copy link

Wigdo commented Jun 8, 2019

I've noticed this as well, being an absolute beginner when it comes to programming/web design I have no idea how to fix this. In almost every other way I think this theme is fantastic. But it would be nice to learn/figure out/ hear some guidance about how to make that transition smooth.

@mmistakes
Copy link
Owner

@Wigdo The menu closes when it detects a click. That's why when you click a link that goes to another page it looks less smooth. This is because the page is loaded before the animation finishes.

I have no idea how you'd fix that. I'd think some JavaScript to wait before the animation finishes before loading the page that was clicked, but I'm no JavaScript expert.

If someone wants to submit a pull request to improve things I'm all for that. Just seeing how this has sat around for almost a year I wouldn't expect much.

@Wigdo
Copy link

Wigdo commented Jun 9, 2019

@mmistakes after manually installing the _data, _includes, and other such folders that you have made available for download in a comprehensive .zip file, the transitions were smoother to the point of being, to me eyes, perfect. Downloading the files via the ordinary ruby gem installation method I noticed jerkiness in that transition/animation but not otherwise. Again, fantastic theme, really loving it ~

@mmistakes
Copy link
Owner

@Wigdo Could be a placebo effect. The ruby gem is identical to what is on GitHub and in the .zip file it produces.

ostadgeorge pushed a commit to ostadgeorge/ostadgeorge2.github.io that referenced this issue Jun 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants