Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Thread is missing in thread list #123

Open
gharlan opened this issue Oct 7, 2019 · 4 comments
Open

Thread is missing in thread list #123

gharlan opened this issue Oct 7, 2019 · 4 comments
Labels

Comments

@gharlan
Copy link

gharlan commented Oct 7, 2019

https://externals.io/message/107388
This thread is missing in thread list (https://externals.io)

@mnapoli mnapoli added the bug label Oct 7, 2019
@mnapoli
Copy link
Owner

mnapoli commented Oct 7, 2019

That's right, I don't have an explanation at the moment (I haven't looked much but the root cause doesn't look obvious right now).

@gharlan
Copy link
Author

gharlan commented Oct 7, 2019

I guess it looks like this:

  1. The mail has In-Reply-To and References header with non existing id (5d976915.1c69fb81.d89d5.5e2fSMTPIN_ADDED_MISSING@mx.google.com)
  2. the threadId is read from References without validation
  3. while inserting the mail, isThreadRoot is set to false, because threadId != mail id

@francislavoie
Copy link
Sponsor Contributor

At this point, there's a few entire threads missing, I've had to revert to reading https://news-web.php.net/php.internals 😢

I would guess that it's related to this change #120 which may not be robust enough to handle certain mails as @gharlan said.

@mnapoli
Copy link
Owner

mnapoli commented Oct 13, 2019

Thanks for investigating @gharlan!

🤔 that's really annoying indeed, I'm not really sure what to do here (I unfortunately have a lot to deal with at the moment so it's hard to sit down and investigate properly). Do you see a solution?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants