Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Thread for message 108848 is missing messages #136

Open
ramsey opened this issue May 15, 2020 · 3 comments
Open

Thread for message 108848 is missing messages #136

ramsey opened this issue May 15, 2020 · 3 comments

Comments

@mnapoli
Copy link
Owner

mnapoli commented May 19, 2020

Hi! The first message does not appear at all because it is a quote (the whole message is a quote, follow the "view source" link: https://externals.io/email/108839/source).

Using CSS we automatically collapse the last quote to avoid having the entire thread history in every message. This doesn't work everytime, especially when authors make mistakes in their formatting.

As for the other messages, that is indeed weird! They seem to be correctly imported in the database (we can view their source: https://externals.io/email/108869/source) and attached to the correct thread (https://externals.io/message/108869 redirects to the correct thread). They just don't display at all.

Maybe parsing their content failed at some point 🤔

@ramsey
Copy link
Author

ramsey commented May 19, 2020

Most of my messages (when I send from my laptop) include a PGP/GPG signature. Is it possible the attachment is causing problems with messages?

@ramsey
Copy link
Author

ramsey commented May 19, 2020

BTW, PHP news-web used to have a similar problem (i.e., messages failing to display if they had attachments), so I had to add some code to handle the attachments.

https://github.com/php/web-news/blob/395a2f411f7eba9307f96715291c3819cfb8e6c2/article.php#L109-L140

I'm not pointing to this code as an example of how you should handle it. It's just for reference.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants