Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

empty message #50

Open
staabm opened this issue Sep 20, 2017 · 4 comments
Open

empty message #50

staabm opened this issue Sep 20, 2017 · 4 comments

Comments

@staabm
Copy link
Contributor

staabm commented Sep 20, 2017

message is rendered empty, even if the plain source contains content
https://externals.io/message/100697#100703
image

raw message https://externals.io/email/100703/source

@mnapoli
Copy link
Owner

mnapoli commented Sep 20, 2017

Thanks, this has to do with the markdown rendering:

> This commit should fix the problem https://github.com/php/php-src/commit/
> 5ef10d08ec2d0823fb21ad189dacfb43d900a0b5
>
>
> Yes! I tested 7.2.0RC2 with this patch applied and it fixes the problem.
Thank you!

Since there is no empty line it is considered as a quotation.

Not sure what to do/if there is anything to do here.

@gharlan
Copy link

gharlan commented Aug 20, 2019

But why is the message empty? Shouldn't the quote be shown anyway?

@mnapoli
Copy link
Owner

mnapoli commented Aug 21, 2019

This is because we hide quotes at the end of messages:

/* Collapse last blockquote of an email */
.email-content>blockquote:last-child {
visibility: hidden;
height: 1em;
position: relative;
&:after {
content: '';
visibility: visible;
position: absolute;
top: 0;
left: 0;
}
}

@AllenJB
Copy link

AllenJB commented Jan 17, 2020

Appears to be another case of the same issue: https://externals.io/message/108175#108176

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants