Skip to content
This repository has been archived by the owner on Jul 13, 2023. It is now read-only.

Tokens in redirect URL need to be of short lifetime #4

Open
muhlemmer opened this issue Dec 20, 2019 · 0 comments
Open

Tokens in redirect URL need to be of short lifetime #4

muhlemmer opened this issue Dec 20, 2019 · 0 comments
Assignees
Labels
enhancement New feature or request
Milestone

Comments

@muhlemmer
Copy link
Contributor

Currently all tokens generated have a single configuration option for Expiration. If this is set to a high interval, it is possible to re-use a URL based token redirect and re-initiate a logged-out session.

Instead, redirected tokens should have a short expiration time. Refreshed tokens usually live in a client session, header or cookie and can have a longer interval. Therefore consumers will need to refresh their token upon the first opportunity after redirect.

The following things need a bit of refactoring:

  1. The authReply method should accept a time.Time instead of looking to the server config.
  2. AuthenticatePwUser and RefreshJWT gRPC methods should accept a time stamp, so the consumer decides the requirements.
  3. Adjust the admin login form to use short timeouts.
@muhlemmer muhlemmer added the enhancement New feature or request label Dec 20, 2019
@muhlemmer muhlemmer added this to the v0.2 milestone Dec 20, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants