Skip to content
This repository was archived by the owner on Dec 31, 2020. It is now read-only.
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: mobxjs/mobx-react
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: 5.2.6
Choose a base ref
...
head repository: mobxjs/mobx-react
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: 5.2.7
Choose a head ref
  • 3 commits
  • 4 files changed
  • 1 contributor

Commits on Sep 10, 2018

  1. Upgraded to React 16.5

    @mweststrate
    mweststrate committed Sep 10, 2018

    Verified

    This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
    GPG key ID: 4AEE18F83AFDEB23
    Expired
    Verified
    Learn about vigilant mode
    Copy the full SHA
    627cada View commit details

  2. Fixed #545, Provider triggers warnign with React 16.5

    @mweststrate
    mweststrate committed Sep 10, 2018
    Copy the full SHA
    b1246b9 View commit details

  3. Published version 5.2.7

    @mweststrate
    mweststrate committed Sep 10, 2018
    Copy the full SHA
    1b74147 View commit details
Showing with 167 additions and 134 deletions.
  1. +4 −0 CHANGELOG.md
  2. +1 −1 package.json
  3. +2 −2 src/Provider.js
  4. +160 −131 yarn.lock
4 changes: 4 additions & 0 deletions CHANGELOG.md
View file
Original file line number Diff line number Diff line change
@@ -1,5 +1,9 @@
# MobX-React Changelog

### 5.2.7

* Fixed issue where React 16.5 printed a warning when using `Provider`, fixes [#545](https://github.com/mobxjs/mobx-react/issues/545)

### 5.2.6

* Fixed bug in defining properties (although the bug had no known observable effect). Fixes [#540](https://github.com/mobxjs/mobx-react/issues/540)
2 changes: 1 addition & 1 deletion package.json
View file
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "mobx-react",
"version": "5.2.6",
"version": "5.2.7",
"description": "React bindings for MobX. Create fully reactive components.",
"main": "index.js",
"jsnext:main": "index.module.js",
4 changes: 2 additions & 2 deletions src/Provider.js
View file
Original file line number Diff line number Diff line change
@@ -15,7 +15,7 @@ class Provider extends Component {

constructor(props, context) {
super(props, context)
this.state = props || {}
this.state = Object.assign({}, props)
}

render() {
@@ -31,7 +31,7 @@ class Provider extends Component {
stores[key] = baseStores[key]
}
// add own stores
for (let key in this.state)
for (let key in this.props)
if (!specialReactKeys[key] && key !== "suppressChangedStoreWarning")
stores[key] = this.props[key]
return {
Loading