README.md

@@ -34,6 +34,7 @@ If you are using [React hooks](https://reactjs.org/docs/hooks-intro.html) with l
 *   Minimal MobX, React, ES6(babel), JSPM with hot reloading modules:
     [jspm-react](https://github.com/capaj/jspm-react)
 *   React Native Counter: [Mobx-React-Native-Counter](https://github.com/bartonhammond/mobx-react-native-counter)
+*   React Native, TypeScript, React Navigation: [Ignite Bowser](https://github.com/infinitered/ignite-bowser)
 
 ## API documentation
 
@@ -201,7 +202,7 @@ class TodoView extends React.Component {
 ```
 
 *   `componentWillReact` doesn't take arguments
-*   `componentWillReact` won't fire before the initial render (use use `componentDidMount` or `constructor` instead)
+*   `componentWillReact` won't fire before the initial render (use `componentDidMount` or `constructor` instead)
 
 ### `PropTypes`
 
@@ -441,7 +442,7 @@ class SomeComponent extends React.Component {
         disposeOnUnmount(this, reaction(...))
 
         // or function array
-        disposeOnUmount(this, [
+        disposeOnUnmount(this, [
             reaction(...),
             reaction(...)
         ])

build-rollup.js

@@ -6,11 +6,26 @@ var resolve = require("rollup-plugin-node-resolve")
 var uglify = require("rollup-plugin-uglify").uglify
 var alias = require("rollup-plugin-alias")
 var replace = require("rollup-plugin-replace")
+var buildVersion = require("./package.json").version
 
 var { rollup } = require("rollup")
 
 var emptyModulePath = path.resolve(__dirname, "empty.js")
 
+var license = ` * Copyright (c) 2015 Michel Weststrate.
+ *
+ * This source code is licensed under the MIT license found in the
+ * LICENSE file in the root directory of this source tree.`
+
+function licenseWrapper(source, version, filename) {
+    return `/** @license mobx-react v${version}
+ * ${filename}
+ *
+${license}
+ */
+${source}`
+}
+
 function getExternals(target) {
     switch (target) {
         case "browser":
@@ -47,7 +62,12 @@ function build(target, mode, filename) {
             module: true,
             main: true
         }),
-        commonjs()
+        commonjs(),
+        {
+            transformBundle(source) {
+                return licenseWrapper(source, buildVersion, filename)
+            }
+        }
     ]
 
     if (mode.endsWith(".min")) {

package.json

@@ -1,6 +1,6 @@
 {
   "name": "mobx-react",
-  "version": "5.4.3",
+  "version": "5.4.4",
   "description": "React bindings for MobX. Create fully reactive components.",
   "main": "index.js",
   "jsnext:main": "index.module.js",

publish.js

@@ -35,9 +35,6 @@ async function prompt(question, defaultValue) {
 }
 
 async function main() {
-    // build
-    run("npm run build")
-
     const pkg = JSON.parse(fs.readFileSync("package.json", "utf8"))
 
     // Bump version number
@@ -68,6 +65,8 @@ async function main() {
 
         fs.writeFileSync("package.json", JSON.stringify(pkg, null, 2), "utf8")
 
+        // build
+        run("npm run build")
         // Finally, commit and publish!
         run("npm publish")
         run(`git commit -am "Published version ${version}"`)

src/utils/utils.js

@@ -5,7 +5,7 @@ export function isStateless(component) {
 }
 
 let symbolId = 0
-export function newSymbol(name) {
+function createSymbol(name) {
     if (typeof Symbol === "function") {
         return Symbol(name)
     }
@@ -14,6 +14,14 @@ export function newSymbol(name) {
     return symbol
 }
 
+const createdSymbols = {}
+export function newSymbol(name) {
+    if (!createdSymbols[name]) {
+        createdSymbols[name] = createSymbol(name)
+    }
+    return createdSymbols[name]
+}
+
 const mobxMixins = newSymbol("patchMixins")
 const mobxPatchedDefinition = newSymbol("patchedDefinition")
 

test/no-symbol.test.js → test/symbol.test.js

@@ -3,6 +3,7 @@ delete global.Symbol
 import React, { Component } from "react"
 import { observer } from "../src"
 import { asyncReactDOMRender, createTestRoot } from "./"
+import { newSymbol } from "../src/utils/utils"
 
 const testRoot = createTestRoot()
 
@@ -16,3 +17,10 @@ test("work without Symbol", async () => {
     )
     await asyncReactDOMRender(<Component1 />, testRoot)
 })
+
+test("cache newSymbol created Symbols", () => {
+    const symbol1 = newSymbol("name")
+    const symbol2 = newSymbol("name")
+
+    expect(symbol1).toEqual(symbol2)
+})