Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clarification on Concurrent Mode Support #2525

Closed
samcooke98 opened this issue Oct 31, 2019 · 5 comments
Closed

Clarification on Concurrent Mode Support #2525

samcooke98 opened this issue Oct 31, 2019 · 5 comments
Labels
💬 discuss 🎁 mobx-react-lite Issue or PR related to mobx-react-lite package

Comments

@samcooke98
Copy link

On the docs, specifically this page https://mobx-react.js.org/state-local there is a commen:

Note that using a local store might conflict with future React features like concurrent rendering.

Is it possible to address why this might conflict? What does conflict mean?

I've seen some discussion about React's ability to rebase, and Michel Westrate suggesting that mobx shouldn't be used for local component state - facebook/react#15317 (comment) - Is this still a valid claim still?


Related issues from around the place,
reduxjs/react-redux#1351 (comment)

reduxjs/react-redux#1351 (comment)

@danielkcz
Copy link
Contributor

danielkcz commented Oct 31, 2019

I guess somebody should actually try it out now when Concurrent is getting finalized. We have some theoretical solution in the next branch which I wanted to release as 2.0 soon, but given that Concurrent is out, it needs to be thoroughly tested.

Although the local state is probably a different beast, I am not sure about specifics either.

@zenVentzi
Copy link

I tried reading through some of the discussions on twitter and other github issues but I couldn't make sense of the whole situation.

In layman terms, how should I approach the situation with local store if I intend on using React's Concurrent mode? Some clarity will be much appreciated!

@danielkcz
Copy link
Contributor

I am unsure about Concurrent mode gotchas myself. First of all, we need to try to run current tests in Concurrent mode. It should be possible with RTL custom render. Help appreciated if anyone is willing to give it a try.

@danielkcz
Copy link
Contributor

danielkcz commented Apr 23, 2020

Just referencing an issue mobxjs/mobx-react-lite#274 that might be worth investigating with Concurrent mode and perhaps add into tests.

@danielkcz danielkcz transferred this issue from mobxjs/mobx-react-lite Oct 18, 2020
@danielkcz danielkcz added 🎁 mobx-react-lite Issue or PR related to mobx-react-lite package 💬 discuss labels Oct 18, 2020
@danielkcz
Copy link
Contributor

Since we have deprecated useLocalStore & useAsObservableSource this is probably outdated issue. Closing for now

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
💬 discuss 🎁 mobx-react-lite Issue or PR related to mobx-react-lite package
Projects
None yet
Development

No branches or pull requests

3 participants