Commit 1192914
1 parent 67d0fac commit 1192914
2 files changed
Original file line number | Diff line number | Diff line change | |
---|---|---|---|
| |||
7 | 7 |
| |
8 | 8 |
| |
9 | 9 |
| |
| 10 | + | |
| 11 | + | |
10 | 12 |
| |
11 | 13 |
| |
12 | 14 |
| |
| |||
50 | 52 |
| |
51 | 53 |
| |
52 | 54 |
| |
53 |
| - | |
54 |
| - | |
55 |
| - | |
56 |
| - | |
57 |
| - | |
58 |
| - | |
59 |
| - | |
60 |
| - | |
61 |
| - | |
62 |
| - | |
63 |
| - | |
64 |
| - | |
65 |
| - | |
66 |
| - | |
67 |
| - | |
68 |
| - | |
69 |
| - | |
70 |
| - | |
71 |
| - | |
| 55 | + | |
| 56 | + | |
| 57 | + | |
| 58 | + | |
| 59 | + | |
| 60 | + | |
| 61 | + | |
| 62 | + | |
| 63 | + | |
| 64 | + | |
| 65 | + | |
| 66 | + | |
| 67 | + | |
| 68 | + | |
| 69 | + | |
| 70 | + | |
| 71 | + | |
| 72 | + | |
| 73 | + | |
72 | 74 |
| |
73 | 75 |
| |
74 | 76 |
| |
| |||
103 | 105 |
| |
104 | 106 |
| |
105 | 107 |
| |
106 |
| - | |
| 108 | + Has conversations. Original line has conversations. | |
107 | 109 |
| |
108 | 110 |
| |
109 | 111 |
| |
|
Original file line number | Diff line number | Diff line change | |
---|---|---|---|
| |||
274 | 274 |
| |
275 | 275 |
| |
276 | 276 |
| |
| 277 | + | |
277 | 278 |
| |
278 | 279 |
| |
279 | 280 |
| |
| |||
312 | 313 |
| |
313 | 314 |
| |
314 | 315 |
| |
315 |
| - | |
| 316 | + |
7 commit comments
Chalk update breaks colors in terminal in 2.4.1 works fine in 2.3.4. It does not show the colors only shows the color codes [[1m
Can confirm it works locally for me as well. @mrjoelkemp as Daniel asked, what shell + OS + terminal emulator are you using?
I'm double interested, as I've helped develop Chalk ;-)
I am using Z shell through Webstorm. Another person having same error is running Cmder with Powershell
@mrjoelkemp could you confirm that your shell supports color codes by placing, e.g.:
console.log("\033[31m Hello World")
somewhere in your test, and confirming the printed string is red?
in Strict mode that throws but I tested it in non strict and it works fine in red:
I fixed the issue in a pull request: #2072
Thanks! I had missed the PR, thanks for creating one. Let's continue the discussion there.