Error in "done() called multiple times" assumptions

[Qard]

This code here will hide the true error of certain failed async tests:

https://github.com/mochajs/mocha/blob/master/lib/runnable.js#L216-L230

To reproduce, try this:

it('should work', function (done) {
  setImmediate(done)
  throw new Error('hidden')
})

You will never see the error with the "hidden" message. It will just tell you done was called twice, which is terribly misleading, as the user code only called it once.

[boneskull]

I'll look into this since it's probably my code.

[LeonFedotov]

👍

[victorbadila]

+1 got the same error in a very similar case. tested this particular case and it happened just as described, I can confirm the behaviour.

[davija]

I am seeing the same behavior. Has this been researched yet? This is almost a year old now.

[kenr]

I'm also experiencing the same problem. Lost about an hour of work figuring out this was a bug in mocha and not the usage of mocha.