Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

throw an exception when using a big value for timeout #1644

Closed
dasilvacontin opened this issue Apr 7, 2015 · 3 comments
Closed

throw an exception when using a big value for timeout #1644

dasilvacontin opened this issue Apr 7, 2015 · 3 comments
Milestone
v3.0.0

Comments

@dasilvacontin
Copy link
Contributor

The exception should remind about the behavior of setTimeout when the timeout value is greater than 2^31. Related: #1643.

This would be a breaking change, and it should be added on a major version.
@dasilvacontin dasilvacontin added the status: accepting prs Mocha can use your help with this one! label Apr 7, 2015
@callumacrae
Copy link
Contributor

I can take this one. Which branch should I use? v3.0.0?

@dasilvacontin
Copy link
Contributor Author

@callumacrae sounds good! :)

callumacrae added a commit to callumacrae/mocha that referenced this issue Apr 13, 2015
@callumacrae
Throw an exception when timeout too large.
4553d82 
closes mochajs#1644
@callumacrae callumacrae mentioned this issue Apr 13, 2015
Merged
callumacrae added a commit to callumacrae/mocha that referenced this issue Apr 13, 2015
@callumacrae
Throw an exception when timeout too large.
ace073d 
closes mochajs#1644
@dasilvacontin dasilvacontin added this to the v3.0.0 milestone Apr 13, 2015
@danielstjules
Copy link
Contributor

Closing since #1652 was merged in the 3.0.0 branch. :)

boneskull pushed a commit that referenced this issue Jul 1, 2016
@callumacrae @boneskull
Throw an exception when timeout too large.
0e7f38f 
closes #1644
boneskull pushed a commit that referenced this issue Jul 2, 2016
@callumacrae @boneskull
Throw an exception when timeout too large.
62818fa 
closes #1644
boneskull pushed a commit that referenced this issue Jul 2, 2016
@callumacrae @boneskull
Throw an exception when timeout too large.
b52b175 
closes #1644
boneskull pushed a commit that referenced this issue Aug 1, 2016
@callumacrae @boneskull
Throw an exception when timeout too large.
fdad1dc 
closes #1644
@boneskull boneskull removed the status: accepting prs Mocha can use your help with this one! label Oct 10, 2016
This was referenced Sep 23, 2018
Closed
Closed
Closed
Closed
@renovate renovate bot mentioned this issue Oct 4, 2018
Closed
1 task
@renovate renovate bot mentioned this issue Nov 14, 2018
Merged
@renovate renovate bot mentioned this issue Nov 23, 2018
Merged
@renovate renovate bot mentioned this issue Dec 7, 2018
Merged
1 task
This was referenced Dec 23, 2018
Closed
Closed
@snyk-bot snyk-bot mentioned this issue Nov 18, 2020
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v3.0.0
Development

No branches or pull requests
4 participants
@callumacrae @danielstjules @boneskull @dasilvacontin