Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace __proto__ throughout with setPrototypeOf shim #1728

Closed
ndhoule opened this issue Jun 7, 2015 · 4 comments
Closed

Replace __proto__ throughout with setPrototypeOf shim #1728

ndhoule opened this issue Jun 7, 2015 · 4 comments
Labels
status: waiting for author waiting on response from OP - more information needed type: chore generally involving deps, tooling, configuration, etc.

Comments

@ndhoule
Copy link
Contributor

ndhoule commented Jun 7, 2015

See #1727 (comment) for details
@ndhoule ndhoule mentioned this issue Jun 7, 2015
Closed
@jbnicolai
Copy link

👍

@boneskull
Copy link
Member

I'm just gonna have to ask why we need to do this in the first place. If we're subclassing, we can use util.inherits(). If we're modifying the prototype of an existing object, well, we probably shouldn't do that.

@boneskull boneskull added status: waiting for author waiting on response from OP - more information needed type: chore generally involving deps, tooling, configuration, etc. labels Jun 10, 2015
@ndhoule
Copy link
Contributor Author

ndhoule commented Jun 10, 2015

util.inherits is fine in Node, but not in the browser, and Browserify's util shim isn't ES3-compatible. We could come up with an ES3-compatible util shim, but at that point, unless we're relying on other functions from util we might as well just use a standalone lib.

@ndhoule ndhoule changed the title Replace __proto__ throughout with Object.setPrototypeOf Replace __proto__ throughout with setPrototypeOf shim Jun 10, 2015
@ndhoule
Copy link
Contributor Author

ndhoule commented Jun 10, 2015

(Sorry, my fault here for naming this issue poorly.)

@ndhoule ndhoule mentioned this issue Jun 17, 2015
Merged
@snyk-bot snyk-bot mentioned this issue Nov 18, 2020
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
status: waiting for author waiting on response from OP - more information needed type: chore generally involving deps, tooling, configuration, etc.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@boneskull @ndhoule @jbnicolai