Stop runner sending SIGINT to itself from within SIGINT handler #1752
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hmm, fair enough. I've done some testing, and all seems to work. Odd that this was originally included in the first place.. |
jbnicolai
pushed a commit
that referenced
this pull request
Jul 4, 2015
Stop runner sending SIGINT to itself from within SIGINT handler
|
@gsilk good catch thx. My bad |
|
@boneskull np |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This prevents an infinite loop when the child process (the target of the runner, ie your tests) installs a SIGINT / SIGTERM handler. You might want to do this, for example, if you need to ensure clean shutdown of your tests when the user presses Ctrl+C. I ran into this problem when spawning a subprocess from the setup portion of my tests, and trying to capture SIGINT in the test suite.