Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

grep links for test names with dots "." don't get escaped correctly. #2070

Open
btelles opened this issue Jan 26, 2016 · 3 comments
Open

grep links for test names with dots "." don't get escaped correctly. #2070

btelles opened this issue Jan 26, 2016 · 3 comments
Labels
area: browser browser-specific area: reporters involving a specific reporter status: waiting for author waiting on response from OP - more information needed type: bug a defect, confirmed by a maintainer

Comments

@btelles
Copy link

btelles commented Jan 26, 2016

Steps to Reproduce:

  1. Create a test whose suite name contains a dot, for example "crud-behavior-basic.html"
  2. Navigate to the test page, for example: http://localhost:5000/test/index.html
  3. Click on the link to "crud-behavior-basic.html"

Expected result:
Link reduces the tests to be run to those inside crud-behavior-basic.html file.
Generated link has: grep=crud-behavior-basic.html

Actual result:
No tests are run.
Generated link has: grep=crud-behavior-basic%5C.html

Related bug: #1687
Related PR: #1698

It appears the following line of code is overzealous. Replacing the . with %5C
https://github.com/benvinegar/mocha/commit/3166e701a356d472656878ae78e5b819099f95d9#diff-998e3fb668a2094eedccab3e56199e4fR204
dfreedm added a commit to Polymer/web-component-tester that referenced this issue Feb 20, 2016
@dfreedm
Fix grep
b5423d8 
Upstream mocha bug is escaping '.' too aggressively
mochajs/mocha#2070

Fixes #282 Fix grep again
@dfreedm dfreedm mentioned this issue Feb 20, 2016
Merged
@btelles
Copy link
Author

btelles commented Feb 24, 2016

Thanks! That definitely fixes it. 👍 :-)

@btelles btelles closed this as completed Feb 24, 2016
@btelles btelles reopened this Jul 7, 2016
@btelles
Copy link
Author

btelles commented Jul 7, 2016 •
edited

The same problem reared its head again in WebComponentTester. Not sure what changed in mocha to add it back in, but just wanted to let you all know.

@drazisil drazisil added the type: bug a defect, confirmed by a maintainer label Mar 30, 2017
@ScottFreeCode ScottFreeCode added status: needs review a maintainer should (re-)review this pull request area: reporters involving a specific reporter unconfirmed area: browser browser-specific labels Sep 22, 2017
@JoshuaKGoldberg
Copy link
Member

JoshuaKGoldberg commented Jan 15, 2024 •
edited

👋 @btelles I'm not familiar with WebComponentTester and don't see a straightforward way to reproduce this in the latest versions of Polymer. I know it's been a few years, but are you able to provide a standalone reproduction for this issue?

No worries if not - just wanted to check in in case you're still hopeful for a resolution!

(for context on why you're only now getting pinged, see #5027)

@JoshuaKGoldberg JoshuaKGoldberg added status: waiting for author waiting on response from OP - more information needed and removed unconfirmed-bug status: needs review a maintainer should (re-)review this pull request labels Jan 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area: browser browser-specific area: reporters involving a specific reporter status: waiting for author waiting on response from OP - more information needed type: bug a defect, confirmed by a maintainer
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@btelles @drazisil @JoshuaKGoldberg @ScottFreeCode