Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

upgrade eslint #2348

Closed
boneskull opened this issue Jul 2, 2016 · 4 comments
Closed

upgrade eslint #2348

boneskull opened this issue Jul 2, 2016 · 4 comments
Labels
nice to have enhancement proposal of low priority type: chore generally involving deps, tooling, configuration, etc.

Comments

@boneskull
Copy link
Member

eslint is stuck at 1.x due to breaking changes. I'm not going to change it for v3.0.0, so sometime thereafter would be fine.
@boneskull boneskull added status: accepting prs Mocha can use your help with this one! type: chore generally involving deps, tooling, configuration, etc. labels Jul 2, 2016
@tjni
Copy link

tjni commented Jul 2, 2016 •
edited

I had some spare time so was looking to do some busy work like this, but ESLint 3 drops support for versions of node < 4. Should we upgrade to 2.x and stay there until a similar decision can be made for Mocha?

@tjni
Copy link

tjni commented Jul 2, 2016

Actually, does the v3.0.0 refer to Mocha or to ESLint? If the former, then that makes sense if Mocha 3 drops support for old versions of node. But it would need to drop even 0.12 for the latest ESLint.

@boneskull
Copy link
Member Author

boneskull commented Jul 3, 2016 •
edited by dasilvacontin

@tjni v3.0.0 refers to Mocha. eslint@2.x.x would be fine, but if we can't get to the latest major it's even less important

@boneskull boneskull added the nice to have enhancement proposal of low priority label Jul 3, 2016
@boneskull
Copy link
Member Author

boneskull commented Jul 22, 2016 •
edited

closed via fb6ef8f in v3.0.0 branch

@boneskull boneskull removed the status: accepting prs Mocha can use your help with this one! label Oct 10, 2016
This was referenced Sep 23, 2018
Closed
Closed
Closed
Closed
@renovate renovate bot mentioned this issue Oct 4, 2018
Closed
1 task
@renovate renovate bot mentioned this issue Nov 14, 2018
Merged
@renovate renovate bot mentioned this issue Nov 23, 2018
Merged
@renovate renovate bot mentioned this issue Dec 7, 2018
Merged
1 task
This was referenced Dec 23, 2018
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
nice to have enhancement proposal of low priority type: chore generally involving deps, tooling, configuration, etc.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@boneskull @tjni