Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

browser tests should cleanup after themselves #2488

Closed
boneskull opened this issue Sep 19, 2016 · 2 comments
Closed

browser tests should cleanup after themselves #2488

boneskull opened this issue Sep 19, 2016 · 2 comments
Labels
nice to have enhancement proposal of low priority status: accepting prs Mocha can use your help with this one!

Comments

@boneskull
Copy link
Member

Currently we have to build Mocha (I think) to use it with karma-mocha. But after the tests are complete, we tend to have a modified mocha.js.

Solution: modify the clean target to git checkout -f -- mocha.js instead of rm -f mocha.js.

I hope that works in Windows.

@boneskull boneskull added the qa label Sep 19, 2016
@boneskull boneskull self-assigned this Sep 19, 2016
@boneskull boneskull removed their assignment Sep 27, 2016
@boneskull boneskull added status: accepting prs Mocha can use your help with this one! nice to have enhancement proposal of low priority labels Sep 27, 2016
@ScottFreeCode
Copy link
Contributor

That git command seems to work fine on Windows as far as I can tell.

@ScottFreeCode
Copy link
Contributor

This was a neat idea, but apparently at some point we opted for the BUILDTMP folder instead, perhaps to ensure that if the cleanup were missed due to failing tests everything would remain OK (and we could then look at the BUILDTMP file from the failed tests if needed for investigation). Feel free to reopen if this issue is still needed for any reason.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
nice to have enhancement proposal of low priority status: accepting prs Mocha can use your help with this one!
Projects
None yet
Development

No branches or pull requests

2 participants