Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unreadable text problem on some color scheme (especially Solarized Dark) #2945

Closed
piroor opened this issue Aug 7, 2017 · 1 comment
Closed

Comments

@piroor
Copy link

piroor commented Aug 7, 2017

Some people say that the mocha's output is unreadable because texts are colorlized quite same to the background color. For example:

Just changing color is not best solution, because there are too many color schemes on the world. It is very hard to keep enough contrast between fixed text color and platform's background color.

Instead, I think some logical control code is better on this case. They reporters say that texts colorized with 90 is unreadable on Solarized Dark. By default the color is applied for pass, error stack, fast, light, and diff gutter; they all mean "weaker than other information" logically. In other words, we just hope that important information to be highlighted and others to be dim. And I've found that the control code 2 means dim which seem to be designed for this purpose. I believe that the logical code 2 is better than phisical color code 90 in this context. Could you consider to use that?

@boneskull
Copy link
Member

sorry, this has been beaten to death.

@mochajs mochajs locked and limited conversation to collaborators Oct 6, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants