Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

馃殌 Feature: Export all BDD functions for "require interface" #2998

Open
ScottFreeCode opened this issue Sep 10, 2017 · 1 comment
Open
Labels
status: accepting prs Mocha can use your help with this one! type: feature enhancement proposal

Comments

@ScottFreeCode
Copy link
Contributor

From my research in #2997, the "require interface's" exports are still missing:

  • specify (alias of it)
  • xspecify (alias of xit)
  • xdescribe (can use context.suite.skip on the TDD side of the ||)
  • context (context.context in this code; alias of describe)
  • xcontext (alias of xdescribe)

It appears that the BDD functions are exported using || to separate BDD and TDD functions they're taken from, basically preferring to take the BDD functions but exporting the TDD functions under BDD names as a fallback, if I've understood the code correctly.

So, each of these should take from the BDD function with the same name; the ones marked "alias of" another should take from the same TDD function as the ones they're aliases of.

These additions don't need tests added unless #2982 is resolved first; if #2982 is resolved first then the added functions should be added to the new/improved test that resolves #2982.

@ScottFreeCode ScottFreeCode added type: bug a defect, confirmed by a maintainer type: chore generally involving deps, tooling, configuration, etc. confirmed nice to have enhancement proposal of low priority status: accepting prs Mocha can use your help with this one! labels Sep 10, 2017
@ScottFreeCode ScottFreeCode self-assigned this Sep 29, 2017
@dimsssss

This comment was marked as outdated.

@JoshuaKGoldberg JoshuaKGoldberg changed the title Export all BDD functions for "require interface" 馃殌 Feature: Export all BDD functions for "require interface" Dec 27, 2023
@JoshuaKGoldberg JoshuaKGoldberg removed type: bug a defect, confirmed by a maintainer status: accepting prs Mocha can use your help with this one! labels Dec 27, 2023
@JoshuaKGoldberg JoshuaKGoldberg added type: feature enhancement proposal status: accepting prs Mocha can use your help with this one! and removed type: chore generally involving deps, tooling, configuration, etc. nice to have enhancement proposal of low priority labels Feb 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status: accepting prs Mocha can use your help with this one! type: feature enhancement proposal
Projects
None yet
Development

No branches or pull requests

4 participants