Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

drop node.js v7 from build matrix; add node.js v9 #3127

Closed
boneskull opened this issue Dec 8, 2017 · 3 comments
Closed

drop node.js v7 from build matrix; add node.js v9 #3127

boneskull opened this issue Dec 8, 2017 · 3 comments
Labels
good first issue new contributors should look here! status: accepting prs Mocha can use your help with this one!

Comments

@boneskull
Copy link
Member

I think it's safe to do this now that npm v5.6.0 has been released.
@boneskull boneskull added good first issue new contributors should look here! status: accepting prs Mocha can use your help with this one! qa labels Dec 8, 2017
@xxczaki
Copy link

xxczaki commented Dec 12, 2017

Yeah, if npm is working on Node.js 9.0 we should definitely add it, but i'm not sure about dropping Node.js 7.0 from build matrix...

@boneskull
Copy link
Member Author

node 7 is not maintained afaik. safe to drop

@xxczaki xxczaki mentioned this issue Dec 14, 2017
Closed
@Bamieh
Copy link
Contributor

Bamieh commented Jan 9, 2018

closing this since the implementation is merged on master (fixed by #3185)

@Bamieh Bamieh closed this as completed Jan 9, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue new contributors should look here! status: accepting prs Mocha can use your help with this one!
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@boneskull @Bamieh @xxczaki