Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

backout deprecation of value returned from suite; closes #3744 #3759

Merged
merged 1 commit into from Feb 21, 2019

Conversation

boneskull
Copy link
Member

This just kills the deprecation as I suggested here.

Signed-off-by: Christopher Hiller <boneskull@boneskull.com>
@boneskull boneskull added type: bug a defect, confirmed by a maintainer semver-patch implementation requires increase of "patch" version number; "bug fixes" labels Feb 21, 2019
@coveralls
Copy link

Coverage Status

Coverage decreased (-0.009%) to 91.719% when pulling 389597f on boneskull/issue/3744 into 7926f47 on master.

@plroebuck
Copy link
Contributor

plroebuck commented Feb 21, 2019

Consider an alternative version, using something like

function isAsync(fn) {
   return fn.constructor.name === 'AsyncFunction';
}

on the describe's function and issuing the deprecation warning based on that.

Or steal Node-10.x's util.types.isAsyncFunction...
See also https://stackoverflow.com/questions/38508420/how-to-know-if-a-function-is-async

@boneskull boneskull added this to the next milestone Feb 21, 2019
@boneskull
Copy link
Member Author

@plroebuck we can revisit after this patch release. I would like to just solve async suites.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
semver-patch implementation requires increase of "patch" version number; "bug fixes" type: bug a defect, confirmed by a maintainer
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants