Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Security update for Mocha v3.5.3 #3792

Closed
nickkolok opened this issue Mar 2, 2019 · 1 comment
Closed

Security update for Mocha v3.5.3 #3792

nickkolok opened this issue Mar 2, 2019 · 1 comment
Labels
status: wontfix typically a feature which won't be added, or a "bug" which is actually intended behavior

Comments

@nickkolok
Copy link

Mocha v3.5.3 is recognized as insecure by npm audit.
I've turned out that updating debug dependence from 2.6.8 to 2.6.9 removes some vulnerabilities.
The appropriate patch is here: https://github.com/nickkolok/mocha/tree/v3.5.3-security-fixes

If growl 1.9.3 will be uploaded to NPM, then we can try to update it, too (see tj/node-growl#81). You cannot use 1.10.* instead.
All the other found vulnerabilities are in dev dependencies.

I know that there is no official LTS support, but I believe that simple publishing a fixed package as 3.5.4 is a good first step to it. Everything is ready, just test (one more time!) and publish.

@boneskull boneskull added the status: wontfix typically a feature which won't be added, or a "bug" which is actually intended behavior label Mar 5, 2019
@boneskull
Copy link
Member

@nickkolok Why do you need to use Mocha v3.5.3?

While we may support LTS releases in the not-too-distant future, the v3 major is too old to be on our radar.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status: wontfix typically a feature which won't be added, or a "bug" which is actually intended behavior
Projects
None yet
Development

No branches or pull requests

2 participants