Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix sponsors background color for readability #3988

Merged
merged 3 commits into from Nov 2, 2019

Conversation

outsideris
Copy link
Member

Description of the Change

If sponsors use white-tone logo, users can't see the sponsor's logo.

스크린샷 2019-08-16 16 41 45

So, I added grey background to sponsors.(And align them center)

스크린샷 2019-08-16 16 55 39

I knew it is not pretty design, but grey is best for both light-tone and dark-tone logos. I thought making sponsor logos readable is more important than pretty design.

Alternate Designs

Another color or design?

Applicable issues

close #3736

@outsideris outsideris added the area: documentation anything involving docs or mochajs.org label Aug 16, 2019
@coveralls
Copy link

coveralls commented Aug 16, 2019

Coverage Status

Coverage increased (+0.07%) to 92.761% when pulling 2fc42d2 on outsideris:sponsor-bg into ec17f63 on mochajs:master.

@outsideris
Copy link
Member Author

스크린샷 2019-08-17 11 50 26

I removed blur.

Signed-off-by: Outsider <outsideris@gmail.com>
Signed-off-by: Outsider <outsideris@gmail.com>
Signed-off-by: Outsider <outsideris@gmail.com>
@outsideris
Copy link
Member Author

Resolved conflicts.

And make sponsor's background like code block style. IMO it's more natural.

스크린샷 2019-10-11 13 34 40

스크린샷 2019-10-11 13 35 27

@outsideris
Copy link
Member Author

I will merge this in a few days.

@outsideris outsideris added the semver-patch implementation requires increase of "patch" version number; "bug fixes" label Nov 2, 2019
@outsideris outsideris merged commit 503d017 into mochajs:master Nov 2, 2019
@outsideris outsideris added this to the next milestone Nov 2, 2019
outsideris added a commit that referenced this pull request Nov 2, 2019
Signed-off-by: Outsider <outsideris@gmail.com>
@outsideris outsideris added the landed-on-v6.2.x cherry-picked on v6.2.x branch from master label Nov 2, 2019
@outsideris outsideris removed the landed-on-v6.2.x cherry-picked on v6.2.x branch from master label Dec 4, 2019
@juergba juergba modified the milestones: next, v7.0.0 Jan 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: documentation anything involving docs or mochajs.org semver-patch implementation requires increase of "patch" version number; "bug fixes"
Projects
None yet
Development

Successfully merging this pull request may close these issues.

make sponsors logo more readable when logo is white in homepage
3 participants