Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

modify alt text of image from Backers to Sponsors inside Sponsors section in Readme #4046

Merged
merged 2 commits into from Oct 13, 2019
Merged

modify alt text of image from Backers to Sponsors inside Sponsors section in Readme #4046

merged 2 commits into from Oct 13, 2019

Conversation

Mia-jeong
Copy link
Contributor

@Mia-jeong Mia-jeong commented Oct 5, 2019 •
edited

When I looked at Readme.md I found out that inside Sponsors sections, the alternative text of images is written as Backer.
so I turned it into Sponsor

스크린샷 2019-10-05 오후 4 54 34

Description of the Change

I changed the text from MochaJS Backer to MochaJS Sponsor

@Mia-jeong
modify alt text of image in Sponsors section
587c15c 
modify alt text of image from [MochaJS Backer] to [MochaJS Sponsors] inside Sponsors section
@Mia-jeong
modify it from Sponsors to Sponsor
c7ff22f
outsideris
outsideris approved these changes Oct 7, 2019
View reviewed changes
Copy link
Member

@outsideris outsideris left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch!

@juergba
Copy link
Member

juergba commented Oct 8, 2019

I just have a question for better understanding.
What is the purpose of this field ![MochaJS Sponsor]?

@Mia-jeong
Copy link
Contributor Author

@juergba Hi :) It's the alternative text of image same as alt of <img />. If the required image is not loading with some reasons. the text in the field will show up on screen instead.

juergba
juergba approved these changes Oct 8, 2019
View reviewed changes
Copy link
Member

@juergba juergba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Mia-jeong thank you

@juergba juergba merged commit 2aef07d into mochajs:master Oct 13, 2019
@juergba juergba added the area: documentation anything involving docs or mochajs.org label Oct 18, 2019
@juergba juergba added this to the 6.2.2 milestone Oct 18, 2019
@juergba juergba added the semver-patch implementation requires increase of "patch" version number; "bug fixes" label Oct 18, 2019
boneskull pushed a commit that referenced this pull request Oct 18, 2019
@Mia-jeong @boneskull
modify alt text of image from Backers to Sponsors inside Sponsors sec…
ee82d38 
…tion in Readme (#4046)
@boneskull boneskull added the landed-on-v6.2.x cherry-picked on v6.2.x branch from master label Oct 18, 2019
This was referenced Oct 27, 2019
Closed
Open
Open
@snyk-bot snyk-bot mentioned this pull request Nov 25, 2019
Open
This was referenced Mar 12, 2020
Merged
Closed
Closed
@snyk-bot snyk-bot mentioned this pull request Apr 9, 2020
Open
@snyk-bot snyk-bot mentioned this pull request Apr 17, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@outsideris outsideris outsideris approved these changes

@juergba juergba juergba approved these changes

Assignees
No one assigned
Labels
area: documentation anything involving docs or mochajs.org landed-on-v6.2.x cherry-picked on v6.2.x branch from master semver-patch implementation requires increase of "patch" version number; "bug fixes"
Projects
None yet
Milestone
v6.2.2
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@Mia-jeong @juergba @outsideris @boneskull