Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

special-case parsing of "require" in unparseNodeArgs(); closes #4035 #4063

Merged
merged 1 commit into from Oct 13, 2019
Merged

special-case parsing of "require" in unparseNodeArgs(); closes #4035 #4063

merged 1 commit into from Oct 13, 2019

Conversation

boneskull
Copy link
Member

this adds a special case when unparseNodeArgs() detects require; it removes the =, which is apparently required for everything else but prohibited in Node.js v8.

@boneskull
special-case parsing of "require" in unparseNodeArgs(); closes #4035
a2fb6d8 
Signed-off-by: Christopher Hiller <boneskull@boneskull.com>
@boneskull boneskull added type: bug a defect, confirmed by a maintainer semver-patch implementation requires increase of "patch" version number; "bug fixes" area: node.js command-line-or-Node.js-specific labels Oct 12, 2019
@boneskull
Copy link
Member Author

if this passes, I'm probably going to cut a release asap since I'm blocking on it

@boneskull boneskull mentioned this pull request Oct 12, 2019
Closed
4 tasks
@coveralls
Copy link

Coverage Status

Coverage remained the same at 92.692% when pulling a2fb6d8 on issue/4035 into ec17f63 on master.

juergba
juergba approved these changes Oct 12, 2019
View reviewed changes
Copy link
Member

@juergba juergba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good, thank you

@juergba juergba merged commit 006d772 into master Oct 13, 2019
@juergba juergba deleted the issue/4035 branch October 13, 2019 07:35
@juergba juergba modified the milestones: next, 6.2.1, 6.2.2 Oct 13, 2019
boneskull added a commit that referenced this pull request Oct 18, 2019
@boneskull
special-case parsing of "require" in unparseNodeArgs(); closes #4035 (#…
e9c036c 
…4063)

Signed-off-by: Christopher Hiller <boneskull@boneskull.com>
@boneskull boneskull added the landed-on-v6.2.x cherry-picked on v6.2.x branch from master label Oct 18, 2019
This was referenced Oct 27, 2019
Closed
Open
Open
@snyk-bot snyk-bot mentioned this pull request Nov 25, 2019
Open
This was referenced Mar 12, 2020
Merged
Closed
Closed
@snyk-bot snyk-bot mentioned this pull request Apr 9, 2020
Open
@snyk-bot snyk-bot mentioned this pull request Apr 17, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@juergba juergba juergba approved these changes

Assignees
No one assigned
Labels
area: node.js command-line-or-Node.js-specific landed-on-v6.2.x cherry-picked on v6.2.x branch from master semver-patch implementation requires increase of "patch" version number; "bug fixes" type: bug a defect, confirmed by a maintainer
Projects
None yet
Milestone
v6.2.2
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@boneskull @coveralls @juergba