Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

2595 Changed runMocha to runMochaJSON in test/integration #4077

Merged
merged 4 commits into from Oct 19, 2019

Conversation

soobing
Copy link
Contributor

@soobing soobing commented Oct 19, 2019

Requirements

  • Filling out the template is required. Any pull request that does not include enough information to be reviewed in a timely manner may be closed at the maintainers' discretion.
  • All new code requires tests to ensure against regressions.

Description of the Change

I tested all integration test file, can change runMocha to runMochaJSON.
There were few things I could change.

Alternate Designs

Why should this be in core?

Benefits

If we're not testing raw reporter output, we should use runMochaJSON() instead.

Possible Drawbacks

nothing

Applicable issues

#2595

  • Is this a breaking change (major release)? no
  • Is it an enhancement (minor release)? no
  • Is it a bug fix, or does it not impact production code (patch release)? no

@jsf-clabot
Copy link

jsf-clabot commented Oct 19, 2019

CLA assistant check
All committers have signed the CLA.

Copy link
Contributor

@craigtaub craigtaub left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree. Thanks for the support. LGTM

@craigtaub craigtaub added semver-patch implementation requires increase of "patch" version number; "bug fixes" qa labels Oct 19, 2019
@craigtaub craigtaub merged commit f73e7c6 into mochajs:master Oct 19, 2019
@craigtaub craigtaub added this to the next milestone Oct 19, 2019
@juergba juergba modified the milestones: next, v7.0.0 Jan 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
semver-patch implementation requires increase of "patch" version number; "bug fixes"
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants