Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Replace ☕ with emoji ☕️ #4092

Merged
merged 1 commit into from Nov 22, 2019
Merged

docs: Replace ☕ with emoji ☕️ #4092

merged 1 commit into from Nov 22, 2019

Conversation

pzrq
Copy link
Contributor

@pzrq pzrq commented Nov 13, 2019

This updates :coffee: to ☕️ (emoji) in the README.md.

As the emoji form, it should then render as an emoji in other places like https://www.npmjs.com/package/mocha

Existing screenshot (MacOS, Firefox 70) for posterity:

Screen Shot 2019-11-13 at 3 26 56 pm

FWIW, it is a non-ASCII character, though Google's JavaScript style guide states:

Tip: Never make your code less readable simply out of fear that some programs might not handle non-ASCII characters properly. If that happens, those programs are broken and they must be fixed.


Requirements

  • Filling out the template is required. Any pull request that does not include enough information to be reviewed in a timely manner may be closed at the maintainers' discretion.
  • All new code requires tests to ensure against regressions.

Description of the Change

Alternate Designs

Why should this be in core?

Benefits

Possible Drawbacks

Applicable issues

To display it in the README.md as the emoji form, which should then render as an emoji in other places like https://www.npmjs.com/package/mocha
@jsf-clabot
Copy link

jsf-clabot commented Nov 13, 2019

CLA assistant check
All committers have signed the CLA.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.07%) to 92.808% when pulling 29d708b on pzrq:patch-1 into b9fbd69 on mochajs:master.

Copy link
Member

@juergba juergba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@pzrq thank you

@juergba juergba merged commit dca588d into mochajs:master Nov 22, 2019
@juergba juergba added the area: documentation anything involving docs or mochajs.org label Nov 22, 2019
@juergba juergba added this to the v7.0.0 milestone Nov 22, 2019
@pzrq pzrq deleted the patch-1 branch December 17, 2019 00:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: documentation anything involving docs or mochajs.org
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants