Update node-environment-flags to 1.0.6 #4118
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
juergba
reviewed
Dec 14, 2019
node-environment-flags 1.0.5 and lower do not contain a LICENSE file which can make compliance difficult.
kylef
force-pushed
the
kylef/node-environment-flags
branch
from
9bb70a6
to
5faba2c
Compare
juergba
approved these changes
Dec 16, 2019
juergba
added
type: chore
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the Change
node-environment-flags 1.0.5 and lower do not contain a LICENSE file which can make compliance difficult. This pull request updates the patch release of node-environment-flags to incorporate boneskull/node-environment-flags#5.
Alternate Designs
Removing the dependency on node-environment-flags.
Why should this be in core?
To ensure the entire dependency chain of Mocha has dependencies contains valid copyright and licenses.
Possible Drawbacks
I don't think there are any.
Applicable issues
It's a bug fix, fixing licensing.