Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CI: add job names, add Node.js v14 to matrix #4242

Merged
merged 1 commit into from Apr 24, 2020
Merged

CI: add job names, add Node.js v14 to matrix #4242

merged 1 commit into from Apr 24, 2020

Conversation

boneskull
Copy link
Member

also fix webhooks

Ref: #4198

@boneskull boneskull added type: chore generally involving deps, tooling, configuration, etc. semver-patch implementation requires increase of "patch" version number; "bug fixes" labels Apr 21, 2020
@boneskull boneskull self-assigned this Apr 21, 2020
@boneskull boneskull mentioned this pull request Apr 21, 2020
Closed
22 tasks
@coveralls
Copy link

Coverage Status

Coverage remained the same at 93.06% when pulling 7fc056c on boneskull/issue/2839-travis into 38d579a on master.

juergba
juergba reviewed Apr 22, 2020
View reviewed changes
.travis.yml Outdated Show resolved Hide resolved
juergba
juergba reviewed Apr 22, 2020
View reviewed changes
Copy link
Member

@juergba juergba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What about Node v14 in appveyor?

@boneskull
Copy link
Member Author

What about Node v14 in appveyor?

I'll add it.

@boneskull
travis: add job names, add Node.js v14 to matrix
07e4f6f 
- fix webhooks
- remove webhook for `mochajs/mocha`
- add v14 to Appveyor

Ref: #4198
@boneskull boneskull changed the title travis: add job names, add Node.js v14 to matrix CI: add job names, add Node.js v14 to matrix Apr 22, 2020
@boneskull boneskull requested a review from juergba April 23, 2020 20:50
juergba
juergba approved these changes Apr 24, 2020
View reviewed changes
Copy link
Member

@juergba juergba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The tests in Node v14 run very slow.

@boneskull
Copy link
Member Author

The tests in Node v14 run very slow.

Where do you see this?

@boneskull boneskull merged commit a94e2d3 into master Apr 24, 2020
@craigtaub craigtaub added this to the next milestone May 21, 2020
@juergba juergba deleted the boneskull/issue/2839-travis branch January 29, 2021 08:41
@Omrisnyk Omrisnyk mentioned this pull request Dec 7, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@juergba juergba juergba approved these changes

Assignees

@boneskull boneskull

Labels
semver-patch implementation requires increase of "patch" version number; "bug fixes" type: chore generally involving deps, tooling, configuration, etc.
Projects
None yet
Milestone
v7.2.0
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@boneskull @coveralls @juergba @craigtaub