parallel mode: enable custom worker reporters and object references #4409
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
boneskull
added
type: feature
boneskull
added
the
status: waiting for author
4 tasks
|
@boneskull Great! I've just tried it with the example from #4403, and now |
boneskull
force-pushed
the
boneskull/issue/4403-object-ids
branch
from
de5bdfc
to
bf91eac
Compare
|
@segrey So this looks good as-is? I'll wrap it up then. |
boneskull
force-pushed
the
boneskull/issue/4403-object-ids
branch
4 times, most recently
from
8211cd6
to
169593a
Compare
boneskull
changed the title
boneskull
removed
the
status: waiting for author
boneskull
force-pushed
the
boneskull/issue/4403-object-ids
branch
2 times, most recently
from
aaa8424
to
87bb39b
Compare
|
@segrey if you can share it, I'd love to see the implementation you've built with this |
boneskull
force-pushed
the
boneskull/issue/4403-object-ids
branch
from
87bb39b
to
6f8a242
Compare
|
@mochajs/core please review, otherwise will merge in next couple days |
boneskull
commented
Sep 30, 2020
|
@boneskull Please see mocha-intellij.zip. Main reporter is There are some minor questions left in #4403 (comment). Would be great if you could take a look. |
- `Suite`s, `Test`s, etc., now have unique identifiers which can optionally be used to re-created object references by a reporter which opts-in to the behavior - A reporter can swap out the worker’s reporter for a custom one - fixed an issue in rollup config causing weird problems - changed how we define `global.Mocha` in `browser-entry.js` (tangential) - removed `object.assign` polyfill (tangential) - renamed misnamed `buffered-runner.spec.js` to `parallel-buffered-runner.spec.js` - added a few unit tests - refactored some tests; mainly modernizing some syntax
Signed-off-by: Christopher Hiller <boneskull@boneskull.com>
the only time this should happen in a non-unit-test context is when a mocha developer introduces a bug also fix a `rewiremock` call in `ParallelBuffered` reporter tests
boneskull
force-pushed
the
boneskull/issue/4403-object-ids
branch
from
16d7960
to
1288205
Compare
boneskull
added
the
semver-minor
|
@segrey This has landed... will be released in next version which will be v8.2.0 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@segrey please see this one. It will allow a reporter to call
runner.linkPartialObjects(true)(see example in docstring) to replace duplicated deserialized objects with references. The objects themselves are still shallow, but if there's a particular property you need that is missing, we can likely add it.I didn't test this too hard, but please let me know if this would help. I'm not sure about the missing
rootprop issue...Ref: #4403
global.Mochainbrowser-entry.js(tangential)object.assignpolyfill (tangential)buffered-runner.spec.jstoparallel-buffered-runner.spec.js