properly dispose Mocha instance in watch mode; closes #4495 #4496
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
boneskull
added
semver-patch
4 tasks
boneskull
commented
Nov 2, 2020
| @@ -415,8 +415,12 @@ async function runMochaWatchAsync(args, opts, change) { | |||
| if (typeof opts === 'string') { | |||
| opts = {cwd: opts}; | |||
| } | |||
| opts = {sleepMs: 2000, ...opts, fork: process.platform === 'win32'}; | |||
| opts.stdio = ['pipe', 'pipe', 'inherit']; | |||
| opts = { | |||
There was a problem hiding this comment.
this was preventing watch mode tests from examining STDERR
boneskull
commented
Nov 2, 2020
| @@ -539,24 +543,25 @@ function sleep(time) { | |||
| module.exports = { | |||
| DEFAULT_FIXTURE, | |||
| SPLIT_DOT_REPORTER_REGEXP, | |||
| copyFixture, | |||
eps1lon
reviewed
Nov 2, 2020
Signed-off-by: Christopher Hiller <boneskull@boneskull.com>
boneskull
force-pushed
the
boneskull/issue/4495-watch-leak
branch
from
97b4dcd
to
014a1b9
Compare
This was referenced Mar 6, 2021
Closed
Closed
This was referenced Mar 8, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
dispose()call before re-instantiationsleep()in integration test helpersRef: #4495