Watch for test files are crashed #4614
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
outsideris
commented
Mar 28, 2021
| @@ -470,6 +470,7 @@ async function runMochaWatchJSONAsync(args, opts, change) { | |||
| // eslint-disable-next-line no-control-regex | |||
| .replace(/\u001b\[\?25./g, '') | |||
| .split('\u001b[2K') | |||
| .filter(x => x) | |||
There was a problem hiding this comment.
I filtered output because the output is an empty string('') when a test file is crashed.
4 tasks
juergba
reviewed
Apr 9, 2021
juergba
added
type: bug
Signed-off-by: Outsider <outsideris@gmail.com>
Signed-off-by: Outsider <outsideris@gmail.com>
outsideris
force-pushed
the
fix-watch-crash-case
branch
from
f0f7458
to
b6b4eef
Compare
|
Fixed |
juergba
added
the
run-browser-test
github-actions
bot
removed
the
run-browser-test
juergba
reviewed
Apr 25, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the Change
In watch mode, the watcher crashed when there are syntax errors in test files during
require('test file').It only happens in serial mode and Node v15+.
This
try - catchstatement removed when we introduce parallel mode.I think we need
try - catchhere.And I added test cases for the crash case to prevent regression.
Why should this be in core?
Watching should be worked.
Benefits
Users can use watch mode when the test code is broken.
Applicable issues
Fix #4580