Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

馃殌 Feature: Unify --ignore and --watch-ignore and make the patterns recursive #5131

Open
3 tasks done
Danielku15 opened this issue Mar 31, 2024 · 0 comments
Open
3 tasks done
Labels
status: in triage a maintainer should (re-)triage (review) this issue type: feature enhancement proposal

Comments

@Danielku15
Copy link

Danielku15 commented Mar 31, 2024

Feature Request Checklist

Overview

Looking at the current behavior of Mocha there is an inconsistency between normal execution and watch execution due to different defaults in --ignore and --watch-ignore.

I think many devs will agree that picking up data from the node_modules folder is not in their interest when maintaining any project and running tests.

Additionally the node_modules folder might live in a subfolder (mono repos) but still is subject of being ignored. The current pattern only ignores node_modules on the level of the mocharc config file.

Suggested Solution

  1. The default values for the two options should be set to the same value.
  2. The default patterns should also ignore these folders if they are in subfolders.

Hence the new default for both options should be similar to: ['**/node_modules/', '**/.git/']

Alternatives

If this is the intended behavior and has a reasoning, this reasoning should be documented on the website.

Additional Info

When using NPM workspaces (common in mono-repos) there will be symlinks from node_modules to the directories of the packages. https://docs.npmjs.com/cli/v10/using-npm/workspaces
Running Mocha with --reporter=json then shows that rather the tests in the node_modules are picked up than the real working directory.

image

This can lead to further problems when processing the test reports or in case external tooling relies on these paths.

The problem became visible while working on a VS Code Extension and tests from node_modules were listed.

CoderLine/mocha-vscode#1

@Danielku15 Danielku15 added status: in triage a maintainer should (re-)triage (review) this issue type: feature enhancement proposal labels Mar 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status: in triage a maintainer should (re-)triage (review) this issue type: feature enhancement proposal
Projects
None yet
Development

No branches or pull requests

1 participant