Spelling #2981

jsoref · 2017-09-04T04:30:43Z

Description of the Change

Spelling fixes

Alternate Designs

This PR can be squashed, and individual changes can be dropped.

Why should this be in core?

These are fixes to existing content.

Benefits

Possible Drawbacks

Applicable issues

Is this a breaking change (major release)?
I don't think so, unless as noted in drawbacks above
Is it an enhancement (minor release)?
Is it a bug fix, or does it not impact production code (patch release)?
I believe so.

jsf-clabot · 2017-09-04T04:30:44Z

All committers have signed the CLA.

ScottFreeCode

Thanks for the PR!

The issue and pull request templates are just files in the repo, by the way, so feel free to add any grammatical/spelling corrections in those to this PR too.

The mocha.js file at the base directory of the project is generated. Changes to Mocha must be made in Mocha's other source files instead. (Any spelling errors in that file that come from Mocha's dependencies can/should be ignored, at least as far as Mocha is concerned -- opening PRs to fix them at their sources would be fine, though we might not get the updates right away. Either way, no updates to the generated mocha.js are relevant -- it will get overwritten before the next release in any case.)

ScottFreeCode · 2017-09-04T05:17:20Z

mocha.js

@@ -13074,7 +13074,7 @@ var process = module.exports = {};
 var cachedSetTimeout;
 var cachedClearTimeout;

-function defaultSetTimout() {
+function defaultSetTimeout() {


To answer a concern from the description: given that this function seems to be local, I don't think it's an API, let alone a public one, so as long as all the references to it were updated this should be fine. (Now, if the name of something it is assigned to were updated, we'd need to check whether that is an API, but I'm pretty sure none of the left-sides for this were changed...)

Ok, turns out this is coming from: https://github.com/defunctzombie/node-process/blob/master/browser.js (or some variant of that). If you can help find the right project for it, that'd help me.

I'd imagine that that is in fact the right project. As I understand it, this defunctzombie guy maintains a bunch of packages that are basically clones of the Node builtins that can be pulled in by Browserify and Webpack.

ScottFreeCode · 2017-09-04T05:23:10Z

test/unit/throw.spec.js

@@ -91,7 +91,7 @@ describe('a test that throws', function () {

    it('should not pass if throwing async and test is async', function (done) {
      var test = new Test('im async and throw null async', function (done2) {
-        process.nexTick(function () {
+        process.nextTick(function () {
          throw null;
        });
      });


Judging from the looks of these corrected tests, I think they were supposed to throw undefined and throw null in the process.nextTick callback, but were actually throwing due to process.nexTick being undefined, and the tests only checked that the attempt failed somewhere along the line and not that it got to the callback and failed by throwing out of the callback. I don't know off the top of my head whether those tests should be checking something to be sure that undefined and null are what's thrown respectively, but they should probably be doing something to prevent treating throws outside the callback as passing. Perhaps wrapping the synchronous portion with try { and } catch (ignore) { /* ensure that early failure due to any problems reaching the callback is not mistaken for the failure we're expecting to get out of the callback when it is asynchronously called */ }?

In any case, some extra eyes on them would be helpful just to make sure that we really are making them better... I'm not absolutely certain I've ascertained their purpose correctly here, and, frankly, I can't quite figure out why there are tests failing in CI now...

I'm going to split this out and leave it for someone else to solve.
I'm on a spelling binge. While I do understand JS and node, I don't really want to spend the time figuring out the right magic to make the test happy.

ScottFreeCode · 2017-09-04T05:24:19Z

mocha.js

@@ -7430,7 +7430,7 @@ function slowToString (encoding, start, end) {
    return ''
  }

-  // Force coersion to uint32. This will also coerce falsey/NaN values to 0.
+  // Force coersion to uint32. This will also coerce falsy/NaN values to 0.


I'm not so sure that "falsey" is incorrect -- niether spelling should show up in a normal spellchecker/dictionary as it's programming jargon, but I've definitely seen the spelling with an E used.

Both are used in this file. This spelling is only used once in the entire repository.

Hrm, by ignoring the mocha.js, the thing goes away, which means that it's coming from some included module. If you happen to know which module, I can fix it there. Otherwise, this will disappear as I rebase back/forth...

Both are used in this file. This spelling is only used once in the entire repository.

Huh, interesting catch -- consistency is definitely a plus then. Well, maybe less so for the package it comes from if it's the only use of the term there, but...

Speaking of which, I may or may not be able to track down which project it's from... It's generally a matter of scrolling up (or is it down? I forget) in the bundled file till you find the name in the bundle glue (the beginning of which will be the package, but the full module path should be in there), then npm view <package name> and looking for GitHub URLs. But if there aren't any GitHub URLs for the package, it gets harder...

ScottFreeCode · 2017-09-04T05:25:21Z

test/browser/ui.spec.js

@@ -19,7 +19,7 @@ describe('$.jQuery', function () {
 });

 // another generic describe block to verify it is absent
-// when greeping on $.jQuery
+// when greping on $.jQuery


I'm also fairly sure that "grepping" is even better than "greping" per typical English language consonant-in-middle-of-word rules, unless using some kind of quote or codeblock-backtick to separate the grep from the "ing", but, eh, anything's better than "greeping" (:laughing:).

Err, yeah. I have no idea why I picked that spelling. Will fix.

coveralls · 2017-09-04T06:11:46Z

Coverage increased (+0.04%) to 89.067% when pulling 0f9a880 on jsoref:spelling into 9f403bf on mochajs:master.

coveralls · 2017-09-04T16:50:05Z

Coverage increased (+0.04%) to 89.067% when pulling b786cdf on jsoref:spelling into 9f403bf on mochajs:master.

ScottFreeCode · 2017-09-04T16:55:21Z

New set of changes looks good! And test failure was unrelated timeout flake; reran and it passed.

This Pull Request updates dependency [mocha](https://github.com/mochajs/mocha) from `v3.1.2` to `v3.5.3` <details> <summary>Release Notes</summary> ### [`v3.5.3`](https://github.com/mochajs/mocha/blob/master/CHANGELOG.md#353--2017-09-11) [Compare Source](mochajs/mocha@v3.5.2...v3.5.3) #### 🐛 Fixes - [#3003]: Fix invalid entities in xUnit reporter first appearing in v3.5.1 ([@jkrems]) [#3003]: `mochajs/mocha#3003 --- ### [`v3.5.2`](https://github.com/mochajs/mocha/blob/master/CHANGELOG.md#352--2017-09-10) [Compare Source](mochajs/mocha@v3.5.1...v3.5.2) #### 🐛 Fixes - [#3001]: Fix AMD-related failures first appearing in v3.5.1 ([@boneskull]) [#3001]: `mochajs/mocha#3001 --- ### [`v3.5.1`](https://github.com/mochajs/mocha/blob/master/CHANGELOG.md#351--2017-09-09) [Compare Source](mochajs/mocha@v3.5.0...v3.5.1) #### 📰 News - 📣 Mocha is now sponsoring [PDXNode](http://pdxnode.org)! If you're in the [Portland](https://wikipedia.org/wiki/Portland,_Oregon) area, come check out the monthly talks and hack nights! #### 🐛 Fixes - [#2997]: Fix missing `xit` export for "require" interface ([@solodynamo]) - [#2957]: Fix unicode character handling in XUnit reporter failures ([@jkrems]) #### 🔩 Other - [#2986]: Add issue and PR templates ([@kungapal]) - [#2918]: Drop bash dependency for glob-related tests ([@ScottFreeCode]) - [#2922]: Improve `--compilers` coverage ([@ScottFreeCode]) - [#2981]: Fix tpyos and spelling errors ([@jsoref]) [#2997]: `mochajs/mocha#2997 [#2957]: `mochajs/mocha#2957 [#2918]: `mochajs/mocha#2918 [#2986]: `mochajs/mocha#2986 [#2922]: `mochajs/mocha#2922 [#2981]: `mochajs/mocha#2981 [@solodynamo]: https://github.com/solodynamo [@jkrems]: https://github.com/jkrems [@jsoref]: https://github.com/jsoref --- ### [`v3.5.0`](https://github.com/mochajs/mocha/blob/master/CHANGELOG.md#350--2017-07-31) [Compare Source](mochajs/mocha@v3.4.2...v3.5.0) #### 📰 News - Mocha now has a [code of conduct](https://github.com/mochajs/mocha/blob/master/.github/CODE_OF_CONDUCT.md) (thanks [@kungapal]!). - Old issues and PRs are now being marked "stale" by [Probot's "Stale" plugin](https://github.com/probot/stale). If an issue is marked as such, and you would like to see it remain open, simply add a new comment to the ticket or PR. - **WARNING**: Support for non-ES5-compliant environments will be dropped starting with version 4.0.0 of Mocha! #### 🔒 Security Fixes - [#2860]: Address [CVE-2015-8315](https://nodesecurity.io/advisories/46) via upgrade of [debug](https://npm.im/debug) ([@boneskull]) #### 🎉 Enhancements - [#2696]: Add `--forbid-only` and `--forbid-pending` flags. Use these in CI or hooks to ensure tests aren't accidentally being skipped! ([@charlierudolph]) - [#2813]: Support Node.js 8's `--napi-modules` flag ([@jupp0r]) #### 🔩 Other - Various CI-and-test-related fixes and improvements ([@boneskull], [@dasilvacontin], [@PopradiArpad], [@Munter], [@ScottFreeCode]) - "Officially" support Node.js 8 ([@elergy]) [#2860]: `mochajs/mocha#2860 [#2696]: `mochajs/mocha#2696 [#2813]: `mochajs/mocha#2813 [@charlierudolph]: https://github.com/charlierudolph [@PopradiArpad]: https://github.com/PopradiArpad [@kungapal]: https://github.com/kungapal [@elergy]: https://github.com/elergy [@jupp0r]: https://github.com/jupp0r --- ### [`v3.4.2`](https://github.com/mochajs/mocha/blob/master/CHANGELOG.md#342--2017-05-24) [Compare Source](mochajs/mocha@v3.4.1...v3.4.2) #### 🐛 Fixes - [#2802]: Remove call to deprecated `os.tmpDir` ([@makepanic]) - [#2820]: Eagerly set `process.exitCode` ([@chrisleck]) #### 🔩 Other - [#2778]: Move linting into an npm script ([@Munter]) [@chrisleck]: https://github.com/chrisleck [@makepanic]: https://github.com/makepanic [@Munter]: https://github.com/Munter [#2778]: `mochajs/mocha#2778 [#2802]: `mochajs/mocha#2802 [#2820]: `mochajs/mocha#2820 --- ### [`v3.4.1`](https://github.com/mochajs/mocha/blob/master/CHANGELOG.md#341--2017-05-14) [Compare Source](mochajs/mocha@v3.3.0...v3.4.1) Fixed a publishing mishap with git's autocrlf settings. --- ### [`v3.3.0`](https://github.com/mochajs/mocha/blob/master/CHANGELOG.md#330--2017-04-24) [Compare Source](mochajs/mocha@v3.2.0...v3.3.0) Thanks to all our contributors, maintainers, sponsors, and users! ❤️ As highlights: - We've got coverage now! - Testing is looking less flaky \o/. - No more nitpicking about "mocha.js" build on PRs. #### 🎉 Enhancements - [#2659]: Adds support for loading reporter from an absolute or relative path ([@sul4bh]) - [#2769]: Support `--inspect-brk` on command-line ([@igwejk]) #### 🐛 Fixes - [#2662]: Replace unicode chars w/ hex codes in HTML reporter ([@rotemdan]) #### 🔍 Coverage - [#2672]: Add coverage for node tests ([@c089], [@Munter]) - [#2680]: Increase tests coverage for base reporter ([@epallerols]) - [#2690]: Increase tests coverage for doc reporter ([@craigtaub]) - [#2701]: Increase tests coverage for landing, min, tap and list reporters ([@craigtaub]) - [#2691]: Increase tests coverage for spec + dot reporters ([@craigtaub]) - [#2698]: Increase tests coverage for xunit reporter ([@craigtaub]) - [#2699]: Increase tests coverage for json-stream, markdown and progress reporters ([@craigtaub]) - [#2703]: Cover .some() function in utils.js with tests ([@seppevs]) - [#2773]: Add tests for loading reporters w/ relative/absolute paths ([@sul4bh]) #### 🔩 Other - Remove bin/.eslintrc; ensure execs are linted ([@boneskull]) - [#2542]: Expand CONTRIBUTING.md ([@boneskull]) - [#2660]: Double timeouts on integration tests ([@Munter]) - [#2653]: Update copyright year ([@Scottkao85], [@Munter]) - [#2621]: Update dependencies to enable Greenkeeper ([@boneskull], [@greenkeeper]) - [#2625]: Use trusty container in travis-ci; use "artifacts" addon ([@boneskull]) - [#2670]: doc(CONTRIBUTING): fix link to org members ([@coderbyheart]) - Add Mocha propaganda to README.md ([@boneskull]) - [#2470]: Avoid test flake in "delay" test ([@boneskull]) - [#2675]: Limit browser concurrency on sauce ([@boneskull]) - [#2669]: Use temporary test-only build of mocha.js for browsers tests ([@Munter]) - Fix "projects" link in README.md ([@boneskull]) - [#2678]: Chore(Saucelabs): test on IE9, IE10 and IE11 ([@coderbyheart]) - [#2648]: Use `semistandard` directly ([@kt3k]) - [#2727]: Make the build reproducible ([@lamby]) [@boneskull]: https://github.com/boneskull [@c089]: https://github.com/c089 [@coderbyheart]: https://github.com/coderbyheart [@craigtaub]: https://github.com/craigtaub [@epallerols]: https://github.com/epallerols [@greenkeeper]: https://github.com/greenkeeper [@igwejk]: https://github.com/igwejk [@kt3k]: https://github.com/kt3k [@lamby]: https://github.com/lamby [@Munter]: https://github.com/Munter [@rotemdan]: https://github.com/rotemdan [@seppevs]: https://github.com/seppevs [@sul4bh]: https://github.com/sul4bh [#2470]: `mochajs/mocha#2470 [#2542]: `mochajs/mocha#2542 [#2621]: `mochajs/mocha#2621 [#2625]: `mochajs/mocha#2625 [#2648]: `mochajs/mocha#2648 [#2653]: `mochajs/mocha#2653 [#2659]: `mochajs/mocha#2659 [#2660]: `mochajs/mocha#2660 [#2662]: `mochajs/mocha#2662 [#2669]: `mochajs/mocha#2669 [#2670]: `mochajs/mocha#2670 [#2672]: `mochajs/mocha#2672 [#2675]: `mochajs/mocha#2675 [#2678]: `mochajs/mocha#2678 [#2680]: `mochajs/mocha#2680 [#2690]: `mochajs/mocha#2690 [#2691]: `mochajs/mocha#2691 [#2698]: `mochajs/mocha#2698 [#2699]: `mochajs/mocha#2699 [#2701]: `mochajs/mocha#2701 [#2703]: `mochajs/mocha#2703 [#2727]: `mochajs/mocha#2727 [#2769]: `mochajs/mocha#2769 [#2773]: `mochajs/mocha#2773 --- ### [`v3.2.0`](https://github.com/mochajs/mocha/blob/master/CHANGELOG.md#320--2016-11-24) [Compare Source](mochajs/mocha@v3.1.2...v3.2.0) #### 📰 News ##### Mocha is now a JS Foundation Project! Mocha is proud to have joined the [JS Foundation](https://js.foundation). For more information, [read the announcement](https://js.foundation/announcements/2016/10/17/Linux-Foundation-Unites-JavaScript-Community-Open-Web-Development/). ##### Contributor License Agreement Under the foundation, all contributors to Mocha must sign the [JS Foundation CLA](https://js.foundation/CLA/) before their code can be merged. When sending a PR--if you have not already signed the CLA--a friendly bot will ask you to do so. Mocha remains licensed under the [MIT license](https://github.com/mochajs/mocha/blob/master/LICENSE). #### 🐛 Bug Fix - [#2535]: Fix crash when `--watch` encounters broken symlinks ([@villesau]) - [#2593]: Fix (old) regression; incorrect symbol shown in `list` reporter ([@Aldaviva]) - [#2584]: Fix potential error when running XUnit reporter ([@vobujs]) #### 🎉 Enhancement - [#2294]: Improve timeout error messaging ([@jeversmann], [@boneskull]) - [#2520]: Add info about `--inspect` flag to CLI help ([@ughitsaaron]) #### 🔩 Other - [#2570]: Use [karma-mocha](https://npmjs.com/package/karma-mocha) proper ([@boneskull]) - Licenses updated to reflect new copyright, add link to license and browser matrix to `README.md` ([@boneskull], [@ScottFreeCode], [@dasilvacontin]) [#2294]: `mochajs/mocha#2294 [#2535]: `mochajs/mocha#2535 [#2520]: `mochajs/mocha#2520 [#2593]: `mochajs/mocha#2593 [#2584]: `mochajs/mocha#2584 [#2570]: `mochajs/mocha#2570 [@Aldaviva]: https://github.com/Aldaviva [@jeversmann]: https://github.com/jeversmann [@ughitsaaron]: https://github.com/ughitsaaron [@villesau]: https://github.com/villesau [@vobujs]: https://github.com/vobujs Thanks to all our contributors, sponsors and backers! Keep on the lookout for a public roadmap and new contribution guide coming soon. --- </details> --- This PR has been generated by [Renovate Bot](https://renovatebot.com).

Spelling

jsoref added 4 commits September 4, 2017 04:07

spelling: amended

ea1789f

spelling: dependency

d8b2054

spelling: grepping

f6b5103

spelling: output

b786cdf

ScottFreeCode suggested changes Sep 4, 2017

View reviewed changes

jsoref added 2 commits September 4, 2017 05:38

spelling: its

32e28e4

spelling: minutes

b85d0ca

jsoref force-pushed the spelling branch from 9b5a2ce to 0f9a880 Compare September 4, 2017 05:53

jsoref mentioned this pull request Sep 4, 2017

fixing process.nexTick (should be process.nextTick), which invalidated tests #2983

Closed

jsoref force-pushed the spelling branch from 0f9a880 to b786cdf Compare September 4, 2017 06:15

ScottFreeCode approved these changes Sep 4, 2017

View reviewed changes

ScottFreeCode merged commit 73a5338 into mochajs:master Sep 4, 2017

jsoref deleted the spelling branch September 4, 2017 18:20

This was referenced Feb 2, 2018

Update dependency mocha to v5 - autoclosed eromano/ci-alarm#63

Closed

Update dependency mocha to v5 - autoclosed dpittner/wurstsalat#28

Closed

Update dependency mocha to v5 signavio/backbone-rel#40

Merged

renovate bot mentioned this pull request Oct 4, 2018

Update dependency mocha to v5 - autoclosed scidock/koa-prerender#5

Closed

1 task

renovate bot mentioned this pull request Oct 22, 2018

Update dependency mocha to v3.5.3 - autoclosed googleapis/nodejs-datastore-session#17

Closed

renovate bot mentioned this pull request Nov 1, 2018

Update dependency mocha to v5 justinbarry/augur-copy#93

Merged

renovate bot mentioned this pull request Nov 14, 2018

Update dependency mocha to v5 hairyhenderson/nursery_alert#17

Merged

renovate bot mentioned this pull request Nov 23, 2018

chore(deps): update dependency mocha to v5 JLHwung/tianzige#37

Merged

This was referenced Dec 23, 2018

Update dependency mocha to v5 - autoclosed mateodelnorte/microsvc-slave#7

Closed

chore(deps): update dependency mocha to v5 status-board/status-board-cli#175

Closed

sgilroy pushed a commit to TwineHealth/mocha that referenced this pull request Feb 27, 2019

Spelling (mochajs#2981)

f59b268

Spelling

snyk-bot mentioned this pull request Mar 15, 2020

[Snyk] Upgrade mocha from 3.4.2 to 3.5.3 postmanlabs/sails-env-switch#14

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Spelling #2981

Spelling #2981

jsoref commented Sep 4, 2017 •

edited

jsf-clabot commented Sep 4, 2017 •

edited

ScottFreeCode left a comment

ScottFreeCode Sep 4, 2017

jsoref Sep 4, 2017

ScottFreeCode Sep 4, 2017

ScottFreeCode Sep 4, 2017

jsoref Sep 4, 2017

ScottFreeCode Sep 4, 2017

jsoref Sep 4, 2017

jsoref Sep 4, 2017

ScottFreeCode Sep 4, 2017

ScottFreeCode Sep 4, 2017

jsoref Sep 4, 2017

coveralls commented Sep 4, 2017

coveralls commented Sep 4, 2017

ScottFreeCode commented Sep 4, 2017

Spelling #2981

Spelling #2981

Conversation

jsoref commented Sep 4, 2017 • edited

Description of the Change

Alternate Designs

Why should this be in core?

Benefits

Possible Drawbacks

Applicable issues

jsf-clabot commented Sep 4, 2017 • edited

ScottFreeCode left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

coveralls commented Sep 4, 2017

coveralls commented Sep 4, 2017

ScottFreeCode commented Sep 4, 2017

jsoref commented Sep 4, 2017 •

edited

jsf-clabot commented Sep 4, 2017 •

edited