Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(ci): Remove PHANTOMJS_CDNURL, nit #3267

Merged
merged 1 commit into from Mar 8, 2018

Conversation

anishkny
Copy link
Contributor

@anishkny anishkny commented Mar 6, 2018

Seems like PHANTOMJS_CDNURL is not needed anymore now that PhantomJS support is depracated.

Please ignore if I am wrong.

Description of the Change

  • Remove PHANTOMJS_CDNURL from .travis.yml because it is not used anymore.
  • Minor edit to comment

Alternate Designs

Why should this be in core?

Benefits

  • Remove cruft

Possible Drawbacks

Applicable issues

Seems like PHANTOMJS_CDNURL is not needed anymore now that PhantomJS support is [depracated](https://github.com/mochajs/mocha/blob/6a796cbbcd6c9f805e482c424327c82ed0398dbf/CHANGELOG.md#compatibility).

Please ignore if I am wrong.
@boneskull boneskull merged commit d76f490 into mochajs:master Mar 8, 2018
@boneskull boneskull added qa semver-patch implementation requires increase of "patch" version number; "bug fixes" labels Mar 8, 2018
@boneskull boneskull added this to the next milestone Mar 8, 2018
This was referenced Sep 22, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
semver-patch implementation requires increase of "patch" version number; "bug fixes"
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants