Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use build stages for Travis CI #3302

Merged
merged 1 commit into from Apr 4, 2018
Merged

Conversation

outsideris
Copy link
Member

Description of the Change

Introduce TravisCI build stages; it's still beta to make our builds more obviously and easier to understand. It groups our builds as lint or test.
I run linting first and then run tests because linting is much cheaper than tests.

Alternate Designs

We can add more stages.
For example, we can use a build stage instead before_script or a coverage stage instead after_success.

Why should this be in core?

IMO, it's more obviously, but it's tiny.
I'm not sure that we should use this yet. It's still beta.

Benefits

Easy to understand our build status.

Possible Drawbacks

If there are some bugs in this feature or Travis change something, our build might be broken, or we should update our .travis.yml.

Applicable issues

#3292

@outsideris outsideris added the qa label Apr 3, 2018
@outsideris outsideris changed the title use Travis build stages use build stages for Travis CI Apr 3, 2018
@coveralls
Copy link

Coverage Status

Coverage increased (+0.05%) to 90.0% when pulling daa7c93 on outsideris:issue-3292 into 9ba8eca on mochajs:master.

@outsideris
Copy link
Member Author

Coverage change is annoying. I will dig the problem when I have enough time.

Copy link
Member

@boneskull boneskull left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks a ton. i'm going to merge this because I want to fiddle with it.

- stage: lint
node_js: '8'
env: TARGET=lint
script: npm start $TARGET
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am guessing this can be simplified into something like

script: npm start $TARGET
node_js: '9'
jobs:
   include:
     - stage: lint
        env: TARGET=lint
     - stage: test # use default node version
        env: TARGET=test.node COVERAGE=true
     - stage: test
        node_js: '8'
        env: TARGET=test.node 
     - stage: test
        node_js : '6'
        env: TARGET=test.node

see https://docs.travis-ci.com/user/build-stages/#Build-Stages-and-Build-Matrix-Expansion

@boneskull boneskull merged commit 35dac3e into mochajs:master Apr 4, 2018
@boneskull boneskull added the semver-patch implementation requires increase of "patch" version number; "bug fixes" label Apr 4, 2018
@boneskull boneskull added this to the v5.1.0 milestone Apr 4, 2018
This was referenced Sep 22, 2018
sgilroy pushed a commit to TwineHealth/mocha that referenced this pull request Feb 27, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
semver-patch implementation requires increase of "patch" version number; "bug fixes"
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants