From 100a42fb8f01aba8c107b011c478c5e293ac15cb Mon Sep 17 00:00:00 2001 From: Outsider Date: Sat, 29 Jun 2019 17:22:08 +0900 Subject: [PATCH 1/3] hide stacktrace when cli args is missing Signed-off-by: Outsider --- lib/cli/options.js | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/lib/cli/options.js b/lib/cli/options.js index fcc619a9b3..f665deb30e 100644 --- a/lib/cli/options.js +++ b/lib/cli/options.js @@ -7,6 +7,7 @@ */ const fs = require('fs'); +const ansi = require('ansi-colors'); const yargsParser = require('yargs-parser'); const {types, aliases} = require('./run-option-metadata'); const {ONE_AND_DONE_ARGS} = require('./one-and-dones'); @@ -131,7 +132,9 @@ const parse = (args = [], defaultValues = {}, ...configObjects) => { boolean: types.boolean.concat(nodeArgs.map(pair => pair[0])) }); if (result.error) { - throw createMissingArgumentError(result.error.message); + const error = createMissingArgumentError(result.error.message); + console.error(ansi.red(`Error: ${error.message}`)); + process.exit(1); } // reapply "=" arg values from above From 76b16871f2fd66c52e444e701f60bcecd9688a8f Mon Sep 17 00:00:00 2001 From: "JeongHoon Byun (aka Outsider)" Date: Wed, 17 Jul 2019 02:37:13 +0900 Subject: [PATCH 2/3] Update lib/cli/options.js Co-Authored-By: David da Silva --- lib/cli/options.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/cli/options.js b/lib/cli/options.js index f665deb30e..738e9ed330 100644 --- a/lib/cli/options.js +++ b/lib/cli/options.js @@ -133,7 +133,7 @@ const parse = (args = [], defaultValues = {}, ...configObjects) => { }); if (result.error) { const error = createMissingArgumentError(result.error.message); - console.error(ansi.red(`Error: ${error.message}`)); + console.error(ansi.red(`Error: ${result.error.message}`)); process.exit(1); } From 775f5427a041bfe54e5afea8cfe228066a37cf60 Mon Sep 17 00:00:00 2001 From: Outsider Date: Wed, 17 Jul 2019 02:40:32 +0900 Subject: [PATCH 3/3] remove unused lines Signed-off-by: Outsider --- lib/cli/options.js | 2 -- 1 file changed, 2 deletions(-) diff --git a/lib/cli/options.js b/lib/cli/options.js index 738e9ed330..a88dbfbf17 100644 --- a/lib/cli/options.js +++ b/lib/cli/options.js @@ -17,7 +17,6 @@ const {loadConfig, findConfig} = require('./config'); const findUp = require('find-up'); const {deprecate} = require('../utils'); const debug = require('debug')('mocha:cli:options'); -const {createMissingArgumentError} = require('../errors'); const {isNodeFlag} = require('./node-flags'); /** @@ -132,7 +131,6 @@ const parse = (args = [], defaultValues = {}, ...configObjects) => { boolean: types.boolean.concat(nodeArgs.map(pair => pair[0])) }); if (result.error) { - const error = createMissingArgumentError(result.error.message); console.error(ansi.red(`Error: ${result.error.message}`)); process.exit(1); }