Skip to content
This repository has been archived by the owner on Jan 4, 2018. It is now read-only.

Pending tests don't show any example output #78

Closed
rcjsuen opened this issue Apr 14, 2017 · 5 comments
Closed

Pending tests don't show any example output #78

rcjsuen opened this issue Apr 14, 2017 · 5 comments

Comments

@rcjsuen
Copy link

rcjsuen commented Apr 14, 2017

In the index.md, it says...

Pending tests will be reported as such.

...and that's all it says. There is no example output provided with the "as such" claim.

@ScottFreeCode
Copy link

Examples of output don't accompany most of the stuff in this document directly, except for one in the very beginning "getting started" section. Most of the examples of output (including some with pending or skipped tests) are in the reporters section.

(That's not necessarily to say it should be that way, just to note that the pending tests section is in this regard consistent with the rest and that output examples are currently available in a dedicated section.)

@rcjsuen
Copy link
Author

rcjsuen commented Apr 15, 2017

My concern is not that "the pending tests section don't have any sample output", it is that the sentence claims "Pending tests will be reported as such." but then proceeds to not provide any sample output. If the sentence didn't exist then it wouldn't matter to me.

To me, "Pending tests will be reported as such." is similar to a "look at the following figure". However, what follows here is nothing. That is what bothers me.

@ScottFreeCode
Copy link

Hmm... I always read this as closer to "pending tests will be reported as pending" -- which, while it sounds redundant when phrased that way, implies that 1) pending tests still get reported and 2) they don't get misleadingly reported as passed or cause the test-suite to count as failed. But I can see where, modulo punctuation, it could be read more like "pending tests will be reported like so:" (and then nothing). Those two points that ought to be conveyed could probably be clearer, perhaps at the expense of a little less brevity.

What if it were changed to something like, "Such incomplete tests will be reported as pending, giving an indicator of their status in the test results while not counting them as failures"?

@rcjsuen
Copy link
Author

rcjsuen commented Apr 16, 2017

Yeah, I realized from this conversation that it was written to mean "Pending tests will be reported as pending".

How about...?

Such incomplete tests will still be included in the test results but as a pending test and not as a failure.

I wanted to use the word "still" to emphasize that while the function itself was empty it would still be included in the test result.

@boneskull
Copy link
Member

This issue was moved to mochajs/mocha#3133

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants