Skip to content
This repository has been archived by the owner on Oct 5, 2021. It is now read-only.

Type added in wrong place #61

Open
Archon- opened this issue Apr 16, 2018 · 1 comment
Open

Type added in wrong place #61

Archon- opened this issue Apr 16, 2018 · 1 comment
Labels
bug Something isn't working

Comments

@Archon-
Copy link

Archon- commented Apr 16, 2018

Steps to reproduce:

  1. Use demo exmaple for Webpack.
  2. Remove definition and usage of displayTypeInfo function.
  3. Run apply-types task.

Actual results:
string type is put in wrong place. See attachment.
zrzut ekranu 2018-04-16 o 14 52 53

Expected
Type is located in correct place.

@urish urish added the bug Something isn't working label Apr 16, 2018
@urish
Copy link
Collaborator

urish commented Apr 16, 2018

Thanks for reporting!

Basically, if I understand correctly, you ran apply-types, and then removed the definition of displayTypeInfo, and then ran apply-types again using the collected type information from the first run?

If so, then this is same as #36 - basically, after running applyTypes once, the source code has already been modified, so the offsets in the collected JSON files are no longer valid. This should improve once #34 is implemented.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants