Skip to content
This repository has been archived by the owner on Oct 5, 2021. It is now read-only.

coverage stat tabulates uses rather than declarations #95

Open
starpit opened this issue Apr 22, 2019 · 3 comments
Open

coverage stat tabulates uses rather than declarations #95

starpit opened this issue Apr 22, 2019 · 3 comments
Labels
component:core enhancement New feature or request help wanted Extra attention is needed

Comments

@starpit
Copy link

starpit commented Apr 22, 2019

the coverage utility is quite helpful. i notice that it increments the penalty for every use of an any variable. maybe this is working as designed, but i think it would be more helpful to penalize any variables once per declaration, rather than once per use?

my thinking is that the magnitude of the fix is proportional to the number of declarations that need to be typed, rather than the number of such uses?

starpit added a commit to starpit/typewiz that referenced this issue Apr 22, 2019
starpit added a commit to starpit/typewiz that referenced this issue Apr 22, 2019
starpit added a commit to starpit/typewiz that referenced this issue Apr 22, 2019
starpit added a commit to starpit/typewiz that referenced this issue Apr 22, 2019
starpit added a commit to starpit/typewiz that referenced this issue Apr 22, 2019
starpit added a commit to starpit/typewiz that referenced this issue Apr 22, 2019
starpit added a commit to starpit/typewiz that referenced this issue Apr 23, 2019
@urish urish added component:core enhancement New feature or request help wanted Extra attention is needed labels Apr 23, 2019
@urish
Copy link
Collaborator

urish commented Apr 23, 2019

Good call! Are you working on a PR?

@starpit
Copy link
Author

starpit commented Apr 24, 2019

yes. i also am working on adding a coverage report. the report will break typecov down by declarations versus parameters versus returns

i'm thinking of dropping identifiers altogether, as focusing on these is probably misleading; this will also increase the scalability of the tool, at least as far as the coverage report is concerned: e.g. in our code base (https://github.com/IBM/kui) there is a roughly 10x difference in magnitude between decls and identifiers.

@urish
Copy link
Collaborator

urish commented Apr 24, 2019

This sounds lovely, I'm looking forward to it. Once we have it, #94 will also make a lot more sense

starpit added a commit to starpit/typewiz that referenced this issue May 14, 2019
starpit added a commit to starpit/typewiz that referenced this issue May 14, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
component:core enhancement New feature or request help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

2 participants