Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mockito BOM doesn't include mockito-inline #3039

Closed
garretwilson opened this issue Jun 15, 2023 · 2 comments
Closed

Mockito BOM doesn't include mockito-inline #3039

garretwilson opened this issue Jun 15, 2023 · 2 comments

Comments

@garretwilson
Copy link

It's great that you offer a Maven bill of materials org.mockito:mockito-bom so that a parent POM can control the Mockito dependency version for whenever child POMs pull in a particular artifact.

Unfortunately unless I'm mistaken it looks like the Mockito BOM does not include org.mockito:mockito-inline. Was this an oversight?

Keep in mind that the BOM is used mostly for <dependencyManagement>; pulling it in doesn't mean we'll actually declare the use of that library. It simply makes sure we're using the latest versions, or versions that work well together. In this case we'll be forced to declare mockito-inline separately.

@garretwilson
Copy link
Author

garretwilson commented Jun 15, 2023

Oh, I'm reading on Stack Overflow that mockito-inline is no longer a separate artifact. And now I'm seeing that you removed it altogether as part of #2877 as of v5.3.0.

Honestly (I noticed this in one of our parent POMs) I can't find exactly why I was using mockito-inline to begin with. I seem to recall that I was doing some sort of static mock, and read online that I needed mockito-inline to do this. I also see that in v5.0.0 apparently you switched to using mockito-inline in the main artifact. So should everything "just work" if I take out the reference to the artifact org.mockito:mockito-inline?

@TimvdLippe
Copy link
Contributor

The inline mockmaker is indeed the default mockmaker since 5.0.0 and we stopped publishing the artifact in 5.3.0. You can replace it with mockito-core to get the same outcome.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants