Add back getArgument(int, Class) to circumvent compilation issues #1646
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also add `@NotExtensible` to several of our interfaces to document they are not intended to be subclassed. Fixes #1609
Codecov Report
@@ Coverage Diff @@
## release/2.x #1646 +/- ##
=================================================
- Coverage 87.38% 87.36% -0.02%
Complexity 2442 2442
=================================================
Files 301 301
Lines 6292 6293 +1
Branches 787 787
=================================================
Hits 5498 5498
- Misses 599 600 +1
Partials 195 195
Continue to review full report at Codecov.
|
|
@mockitoguy could you take a look? We need this for a couple of our projects. |
|
We need this for internal projects. Since @mockitoguy gave approval for this in #1609 (comment) and other engineers reviewed this internally, I am merging this PR. |
|
Good work, thank you! Sorry I was late to review. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also add
@NotExtensibleto several of our interfaces to document theyare not intended to be subclassed.
Fixes #1609