Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[build] update gradle-errorprone-plugin to 1.1.0 #1908

Merged
merged 1 commit into from Jun 19, 2020

Conversation

grimreaper
Copy link
Contributor

@grimreaper grimreaper commented Apr 13, 2020

Problem
The plugin for error-prone is out of date

Solution
Update the plugin.

  • Read the contributing guide
  • PR should be motivated, i.e. what does it fix, why, and if relevant how
  • If possible / relevant include an example in the description, that could help all readers
    including project members to get a better picture of the change
  • Avoid other runtime dependencies
  • Meaningful commit history ; intention is important please rebase your commit history so that each
    commit is meaningful and help the people that will explore a change in 2 years
  • The pull request follows coding style
  • Mention Fixes #<issue number> in the description if relevant
  • At least one commit should mention Fixes #<issue number> if relevant

@TimvdLippe
Copy link
Contributor

We should probably first update our Travis testing matrix to remove testing on Java 9 and 10, and adding Java 14. Then we can look into the failures with ErrorProne on Java 12. I will also contact the ErrorProne team to get them look at the problems.

@grimreaper
Copy link
Contributor Author

agreed: though this is unrelated. I just tried this before realizing the problem was java 12 :)

@TimvdLippe
Copy link
Contributor

Apparently the JDK 12 issue is being tracked at google/error-prone#1106

@codecov-io
Copy link

codecov-io commented May 3, 2020

Codecov Report

Merging #1908 into release/3.x will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@              Coverage Diff               @@
##             release/3.x    #1908   +/-   ##
==============================================
  Coverage          86.67%   86.67%           
  Complexity          2526     2526           
==============================================
  Files                318      318           
  Lines               6650     6650           
  Branches             832      832           
==============================================
  Hits                5764     5764           
  Misses               685      685           
  Partials             201      201           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bd3c45a...57bdb7b. Read the comment docs.

@TimvdLippe
Copy link
Contributor

Upstream has fixed their support for newer versions of Java. @grimreaper could you rebase this PR?

@codecov-commenter
Copy link

codecov-commenter commented Jun 19, 2020

Codecov Report

Merging #1908 into release/3.x will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@              Coverage Diff               @@
##             release/3.x    #1908   +/-   ##
==============================================
  Coverage          85.76%   85.76%           
  Complexity          2542     2542           
==============================================
  Files                318      318           
  Lines               7209     7209           
  Branches             861      861           
==============================================
  Hits                6183     6183           
  Misses               810      810           
  Partials             216      216           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4fd405d...fac7716. Read the comment docs.

@grimreaper
Copy link
Contributor Author

done

gradle/errorprone.gradle Outdated Show resolved Hide resolved
Problem
The plugin for error-prone is out of date

Solution
Update the plugin.
@TimvdLippe TimvdLippe merged commit 397b4d2 into mockito:release/3.x Jun 19, 2020
epeee pushed a commit to epeee/mockito that referenced this pull request Jun 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants