[build] bump gradle to latest 5.x release #1923
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Problem Gradle is out date which results in us not having bugs fixed, new features, or performance improvements Solution Upgrade gradle to the latest 5.x (current major version we use). Also switch from `-bin` to `-all` which mildly increases distribution size but makes it much easier to debug or diagnose issues. This has no impact to end users.
grimreaper
force-pushed
the
eax/gw/bump-gradle-to-latest-5
branch
from
4584d40
to
5c6356a
Compare
TimvdLippe
added a commit
that referenced
this pull request
Jun 15, 2020
This included a couple of breaking changes: - The build plugin is now part of the Gradle Enterprise plugin - The osgi plugin was removed, for which we have to use the bndtools plugin instead - Kotlin version has to be updated, including their coroutine library versions Gradle 6 is required for us to build on Java 14. Supersedes and closes #1923
Merged
TimvdLippe
added a commit
that referenced
this pull request
Jun 16, 2020
* Upgrade to Gradle 6 This included a couple of breaking changes: - The build plugin is now part of the Gradle Enterprise plugin - The osgi plugin was removed, for which we have to use the bndtools plugin instead - Kotlin version has to be updated, including their coroutine library versions Gradle 6 is required for us to build on Java 14. Supersedes and closes #1923 * Remove commented plugin * Move checksum computation out of Gradle Gradle 6 does not like that we run a build twice, as part of a Gradle task. Therefore, we have to move the checksum computation out of the gradle task in a separate Bash script. * Run reproducibility check as a separate Travis build Otherwise we lose the code coverage, as we run a `gradle clean` in the reproducibility check. * Fix code coverage This now also makes use of the build cache, which should significantly speed up Travis builds. * Fix disabling of projects for the coverage task * Fix exclusion of errorprone subproject * Reverse logic in coverage.gradle
epeee
pushed a commit
to epeee/mockito
that referenced
this pull request
Jun 22, 2020
* Upgrade to Gradle 6 This included a couple of breaking changes: - The build plugin is now part of the Gradle Enterprise plugin - The osgi plugin was removed, for which we have to use the bndtools plugin instead - Kotlin version has to be updated, including their coroutine library versions Gradle 6 is required for us to build on Java 14. Supersedes and closes mockito#1923 * Remove commented plugin * Move checksum computation out of Gradle Gradle 6 does not like that we run a build twice, as part of a Gradle task. Therefore, we have to move the checksum computation out of the gradle task in a separate Bash script. * Run reproducibility check as a separate Travis build Otherwise we lose the code coverage, as we run a `gradle clean` in the reproducibility check. * Fix code coverage This now also makes use of the build cache, which should significantly speed up Travis builds. * Fix disabling of projects for the coverage task * Fix exclusion of errorprone subproject * Reverse logic in coverage.gradle
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Gradle is out date which results in us not having bugs fixed, new
features, or performance improvements
Solution
Upgrade gradle to the latest 5.x (current major version we use). Also
switch from
-binto-allwhich mildly increases distribution sizebut makes it much easier to debug or diagnose issues. This has no impact
to end users.
including project members to get a better picture of the change
commit is meaningful and help the people that will explore a change in 2 years
Fixes #<issue number>in the description if relevantFixes #<issue number>if relevant