Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[checkstyle] switch to new DTD #1940

Merged
merged 1 commit into from May 27, 2020
Merged

[checkstyle] switch to new DTD #1940

merged 1 commit into from May 27, 2020

Conversation

grimreaper
Copy link
Contributor

@grimreaper grimreaper commented May 27, 2020 •
edited

Problem

The location for the checkstyle DTD has moved.

Solution

Update DTD location

@grimreaper
[checkstyle] switch to new DTD
0ccb85d 
Problem

The location for the checkstyle DTD has moved.

Solution

Update DTD location
@grimreaper grimreaper changed the title > Hey, > > Thanks for the contribution, this is awesome. > As you may have read, project members have somehow an opinionated view on what and how should be > Mockito, e.g. we don't want mockito to be a feature bloat. > There may be a thorough review, with feedback -> code change loop. > > Which branch : > - On mockito 3.x, make your pull request target release/3.x > - On mockito 2.x, make your pull request target release/2.x (2.x is in maintenance mode) > > _This block can be removed_ > _Something wrong in the template fix it here .github/PULL_REQUEST_TEMPLATE.md [checkstyle] switch to new DTD May 27, 2020
@codecov-commenter
Copy link

codecov-commenter commented May 27, 2020 •
edited

Codecov Report

Merging #1940 into release/3.x will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@              Coverage Diff               @@
##             release/3.x    #1940   +/-   ##
==============================================
  Coverage          86.67%   86.67%           
  Complexity          2526     2526           
==============================================
  Files                318      318           
  Lines               6650     6650           
  Branches             832      832           
==============================================
  Hits                5764     5764           
  Misses               685      685           
  Partials             201      201

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1983c75...0ccb85d. Read the comment docs.

TimvdLippe
TimvdLippe approved these changes May 27, 2020
View reviewed changes
Copy link
Contributor

@TimvdLippe TimvdLippe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@TimvdLippe TimvdLippe merged commit 6620170 into mockito:release/3.x May 27, 2020
epeee pushed a commit to epeee/mockito that referenced this pull request Jun 22, 2020
@grimreaper @epeee
[checkstyle] Switch to new DTD (mockito#1940)
69db816 
The location for the checkstyle DTD has moved.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TimvdLippe TimvdLippe TimvdLippe approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@grimreaper @codecov-commenter @TimvdLippe