Move spotless check to separate build task #1946
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
9/10 are EOL since September 2018. 14 is the currently supported Java version.
This means the tests can run in parallel of the formatting changes. Therefore, formatting changes would not block obtaining your test results, which should hopefully reduce the amount of Travis builds necessary to work on a community PR. This is also in preparation of #1934 which requires spotless to run on JDK11 minimum.
This included a couple of breaking changes: - The build plugin is now part of the Gradle Enterprise plugin - The osgi plugin was removed, for which we have to use the bndtools plugin instead - Kotlin version has to be updated, including their coroutine library versions Gradle 6 is required for us to build on Java 14. Supersedes and closes #1923
mockitoguy
approved these changes
Jun 16, 2020
| @@ -28,6 +28,9 @@ matrix: | |||
| env: SKIP_RELEASE=true | |||
| - jdk: openjdk14 | |||
| env: SKIP_RELEASE=true MOCK_MAKER=mock-maker-inline | |||
| - jdk: openjdk11 | |||
| script: ./gradlew spotlessCheck | |||
There was a problem hiding this comment.
Does script: ./gradlew spotlessCheck mean that on openjdk11 we only run "spotlessCheck" task?
There was a problem hiding this comment.
It means that we have 1 task that only runs spotless, and that task runs on opendjk11. We still have the other openjdk11 builds to verify that the tests pass etc... I will add a comment for clarification.
| @@ -28,6 +28,9 @@ matrix: | |||
| env: SKIP_RELEASE=true | |||
| - jdk: openjdk14 | |||
| env: SKIP_RELEASE=true MOCK_MAKER=mock-maker-inline | |||
| - jdk: openjdk11 | |||
| script: ./gradlew spotlessCheck | |||
| after_success: true | |||
There was a problem hiding this comment.
What does after_success: true do here?
There was a problem hiding this comment.
To make sure we don't run the coverage report task, since that's not what spotless generates. I will add a clarifying comment.
epeee
pushed a commit
to epeee/mockito
that referenced
this pull request
Jun 22, 2020
This means the tests can run in parallel of the formatting changes. Therefore, formatting changes would not block obtaining your test results, which should hopefully reduce the amount of Travis builds necessary to work on a community PR. This is also in preparation of mockito#1934 which requires spotless to run on JDK11 minimum.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This means the tests can run in parallel of the formatting changes.
Therefore, formatting changes would not block obtaining your test
results, which should hopefully reduce the amount of Travis builds
necessary to work on a community PR.
This is also in preparation of #1934 which requires spotless to
run on JDK11 minimum.