Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document using @Mock with method parameters #1961

Merged
merged 1 commit into from Jun 29, 2020

Conversation

jamietanna
Copy link
Contributor

Although we've called it out in the JUnit extension, we should also
make sure it's clear in the core documentation to make it more visible.

We can fully-quality the @Test annotation to make clear that it has to
be with JUnit 5.

Closes #1960.

Although we've called it out in the [JUnit extension], we should also
make sure it's clear in the core documentation to make it more visible.

We can fully-quality the `@Test` annotation to make clear that it has to
be with JUnit 5.

Closes mockito#1960.

[JUnit extension]: https://javadoc.io/doc/org.mockito/mockito-junit-jupiter/latest/org/mockito/junit/jupiter/MockitoExtension.html
@codecov-commenter
Copy link

codecov-commenter commented Jun 29, 2020

Codecov Report

Merging #1961 into release/3.x will increase coverage by 0.02%.
The diff coverage is n/a.

Impacted file tree graph

@@                Coverage Diff                @@
##             release/3.x    #1961      +/-   ##
=================================================
+ Coverage          85.77%   85.80%   +0.02%     
  Complexity          2543     2543              
=================================================
  Files                318      318              
  Lines               7215     7215              
  Branches             861      861              
=================================================
+ Hits                6189     6191       +2     
  Misses               810      810              
+ Partials             216      214       -2     
Impacted Files Coverage Δ Complexity Δ
src/main/java/org/mockito/Mockito.java 96.61% <ø> (ø) 42.00 <0.00> (ø)
...to/internal/util/concurrent/WeakConcurrentMap.java 41.48% <0.00%> (+2.12%) 11.00% <0.00%> (ø%)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0501e02...87be4b1. Read the comment docs.

Copy link
Contributor

@TimvdLippe TimvdLippe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@TimvdLippe TimvdLippe merged commit 87aacae into mockito:release/3.x Jun 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Documentation: @Mock on method parameters
3 participants