Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #1855 and #939: improve error message when the inline mock maker cannot be used. #1974

Merged
merged 1 commit into from Jul 18, 2020

Conversation

raphw
Copy link
Member

@raphw raphw commented Jul 16, 2020

Improves the error message and does not create a hard dependency on the compiler module. It also points out that Byte Buddy can now emulate the attachment API using JNA if it's added to the class path.

@raphw raphw requested a review from TimvdLippe July 16, 2020 18:45
@codecov-commenter
Copy link

codecov-commenter commented Jul 16, 2020

Codecov Report

Merging #1974 into release/3.x will decrease coverage by 0.07%.
The diff coverage is 0.00%.

Impacted file tree graph

@@                Coverage Diff                @@
##             release/3.x    #1974      +/-   ##
=================================================
- Coverage          85.41%   85.34%   -0.08%     
  Complexity          2601     2601              
=================================================
  Files                322      322              
  Lines               7496     7505       +9     
  Branches             897      898       +1     
=================================================
+ Hits                6403     6405       +2     
- Misses               855      864       +9     
+ Partials             238      236       -2     
Impacted Files Coverage Δ Complexity Δ
...l/creation/bytebuddy/InlineByteBuddyMockMaker.java 57.98% <0.00%> (-3.27%) 18.00 <0.00> (ø)
...to/internal/util/concurrent/WeakConcurrentMap.java 41.48% <0.00%> (+2.12%) 11.00% <0.00%> (ø%)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6635dee...12ba593. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants